[GitHub] madlib pull request #248: DT: Ensure proper quoting in grouping coalesce

2018-03-27 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/248#discussion_r177503935 --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in --- @@ -970,16 +970,35 @@ def _get_bins_grps(

[GitHub] madlib pull request #248: DT: Ensure proper quoting in grouping coalesce

2018-03-27 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/248#discussion_r177495864 --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in --- @@ -970,16 +970,35 @@ def _get_bins_grps(

[GitHub] madlib pull request #248: DT: Ensure proper quoting in grouping coalesce

2018-03-22 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/248 DT: Ensure proper quoting in grouping coalesce JIRA: MADLIB-1217 Grouping column value is coalesced with null_proxy to get the right null identifier when null_as_category is True. The