[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

2018-06-27 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/284
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/528/



---


[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

2018-06-27 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/284
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/527/



---


[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

2018-06-27 Thread njayaram2
Github user njayaram2 commented on the issue:

https://github.com/apache/madlib/pull/284
  
Thank you for the comment @iyerr3 , will relax the constraint as suggested.


---


[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

2018-06-27 Thread iyerr3
Github user iyerr3 commented on the issue:

https://github.com/apache/madlib/pull/284
  
This test isn't necessarily the best thing to check but if we do want to 
keep it with some relaxed constraints then maybe we allow the norm to go higher 
by a small amount iff the total loss is lower. So something along the lines of 
```
norm2(l2.coef) < norm2(noreg.coef) OR
( (norm2(l2.coef)-norm2(noreg.coef))/norm2(noreg.coef) < 0.1 AND 
l2.loss < noreg.loss),
```


---