[GitHub] madlib pull request #278: Upgrade: add changelist file and bug fixes

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/madlib/pull/278


---


[GitHub] madlib pull request #278: Upgrade: add changelist file and bug fixes and cha...

2018-06-11 Thread kaknikhil
GitHub user kaknikhil opened a pull request:

https://github.com/apache/madlib/pull/278

Upgrade: add changelist file and bug fixes and changelist file

This PR  adds a changelist file for testing 1.14 to 1.15 upgrade and 
addresses 2 bugs we found during upgrade testing.
1. Commit 8e34f68 added a new function called `_write_to_file` that takes 2 
arguments.
Some of the calls to this function were not passing the first file handle 
argument.
2. Append schema_madlib to the mlp_igd_final return type. This caused the
upgrade to fail from 1.12 to 1.x if there was a dependency on
mlp_igd_final.

Co-authored-by : Orhan Kislal 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/madlib/madlib 
feature/automate_upgrade_failure_sql

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #278


commit b011d8eb261f7b42b17a45fa9d881a4bebb69960
Author: Nikhil Kak 
Date:   2018-06-06T23:35:22Z

Upgrade: Fix 1.12 to 1.13 changelist

Append schema_madlib to the mlp_igd_final return type. This caused the
upgrade to fail from 1.12 to 1.x if there was a dependency on
mlp_igd_final.

Co-authored-by : Orhan Kislal 

commit 979036528167a9ff9d1352550c5d4650504efe72
Author: Nikhil Kak 
Date:   2018-06-07T17:54:30Z

Upgrade: Add empty changelist for 1.14 to 1.15-dev

This changelist will be filled in before the 1.15 release.  We will
need to rename this during the 1.15 release from 1.14_1.15-dev.yaml to
1.14_1.15.yaml.

commit 6d0cde5cfaa2fe6051d02ee2e5add3f77c344067
Author: Nikhil Kak 
Date:   2018-06-07T19:00:58Z

Upgrade: Fix missing filehandle arg from _write_to_file calls

Commit 8e34f68d7f7b902ebe511b934683724dc2d5dcca added a new function called 
`_write_to_file` that takes 2 arguments.
Some of the calls to this function were not passing the first file handle 
argument.




---