[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF

2018-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/283 ---

[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF

2018-06-27 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/283#discussion_r198641216 --- Diff: src/ports/postgres/modules/crf/test/crf_train_large.sql_in --- @@ -234,26 +234,40 @@ INSERT INTO train_new_segmenttbl VALUES (30, 7,

[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF

2018-06-27 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/283#discussion_r198644242 --- Diff: src/ports/postgres/modules/crf/test/crf_test_small.sql_in --- @@ -90,7 +90,7 @@ (18,'PRP$'),(19,'RB'), (20,'RBR'), (21,'RBS'),

[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF

2018-06-27 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/283 Bugfix: Fix failing dev check in CRF This commit has the following changes: - A couple of dev check files in CRF did not have the label table creation in it. But the label table was