[GitHub] madlib pull request #290: madpack: Add madpack option to run unit tests.

2018-07-16 Thread njayaram2 
Github user njayaram2 closed the pull request at:

https://github.com/apache/madlib/pull/290


---

[GitHub] madlib pull request #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread iyerr3 
Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/madlib/pull/290#discussion_r201876197
  
--- Diff: 
src/ports/postgres/modules/convex/test/unit_tests/test_mlp_igd.py_in ---
@@ -126,10 +126,11 @@ class MLPMiniBatchTestCase(unittest.TestCase):
 'dependent_varname': 
'value',
 'class_values': 
'regression',
 'grouping_cols': 'value',
+'dependent_vartype': 
'value',
 'foo': 'bar'}]
 self.module = self.subject.MLPMinibatchPreProcessor("input")
 self.assertTrue(self.module.preprocessed_summary_dict)
-self.assertEqual(5, len(self.module.preprocessed_summary_dict))
+self.assertEqual(6, len(self.module.preprocessed_summary_dict))
--- End diff --

Let's put this as a separate commit (can be pushed to master already) since 
it's unrelated to this PR. 


---

[GitHub] madlib pull request #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread njayaram2 
GitHub user njayaram2 opened a pull request:

https://github.com/apache/madlib/pull/290

madpack: Add madpack option to run unit tests.

JIRA: MADLIB-1252

Unit tests in MADlib are written in python files, that are located in
the .../test/unit_tests/ folders, whose names begin with
the prefix "test_". This commit adds a new madpack option to run unit
tests similar to how we run install and dev checks.

- The new option added is: `unit-test`.
- Sample usage (on a postgres database, with MADlib installed on
  database `madlib`):
  * Run unit tests on all modules that have it defined:
  src/bin/madpack -p postgres -c /madlib unit-test
  * Run unit tests only for the `convex` module:
  src/bin/madpack -p postgres -c /madlib unit-test -t convex
  * Run unit tests only for the `convex` and decision trees module:
  src/bin/madpack -p postgres -c /madlib unit-test -t
  convex,recursive_partitioning/decision_tree
- Add command to run all unit tests in Jenkins build script.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/madlib/madlib madpack/unit-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #290


commit 5f4395bc8548a5f74ba9a8fcb716f2a39ec51162
Author: Nandish Jayaram 
Date:   2018-07-11T00:32:24Z

madpack: Add madpack option to run unit tests.

JIRA: MADLIB-1252

Unit tests in MADlib are written in python files, that are located in
the .../test/unit_tests/ folders, whose names begin with
the prefix "test_". This commit adds a new madpack option to run unit
tests similar to how we run install and dev checks.

- The new option added is: `unit-test`.
- Sample usage (on a postgres database, with MADlib installed on
  database `madlib`):
  * Run unit tests on all modules that have it defined:
  src/bin/madpack -p postgres -c /madlib unit-test
  * Run unit tests only for the `convex` module:
  src/bin/madpack -p postgres -c /madlib unit-test -t convex
  * Run unit tests only for the `convex` and decision trees module:
  src/bin/madpack -p postgres -c /madlib unit-test -t
  convex,recursive_partitioning/decision_tree
- Add command to run all unit tests in Jenkins build script.




---