[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/314 ---
[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Github user reductionista commented on a diff in the pull request:
https://github.com/apache/madlib/pull/314#discussion_r213069972
--- Diff: deploy/CMakeLists.txt ---
@@ -27,9 +26,21 @@ elseif(UNIX)
)
elseif(IS_DEBIAN)
message(STATUS "Detected Debian version ${DEB_VERSION}")
-list(APPEND CPACK_GENERATOR
-DEB
-)
+# -- If cmake flag -DCREATE_RPM_FOR_UBUNTU is set to some
+# value, then we will create an RPM on Ubuntu. If that
+# flag is not set to any value in cmake, then we create
+# only .deb artifact on Ubuntu.
+# Note that package alien must already be installed for
--- End diff --
The comment makes it sound as if setting -DCREATE_RPM_FOR_UBUNTU would
build both .rpm and .deb while not setting it "only" builds .deb.
But looking at the code itself, only one or the other is built but never
both. Assuming this is intentional, I would suggest removing "only" from the
comment for clarity.
---
[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
Github user reductionista commented on a diff in the pull request:
https://github.com/apache/madlib/pull/314#discussion_r213063053
--- Diff: deploy/CMakeLists.txt ---
@@ -27,9 +26,21 @@ elseif(UNIX)
)
elseif(IS_DEBIAN)
message(STATUS "Detected Debian version ${DEB_VERSION}")
-list(APPEND CPACK_GENERATOR
-DEB
-)
+# -- If cmake flag -DCREATE_RPM_FOR_UBUNTU is set to some
+# value, then we will create an RPM on Ubuntu. If that
+# flag is not set to any value in cmake, then we create
+# only .deb artifact on Ubuntu.
+# Note that package alien must already be installed for
+# building an RPM on Ubuntu.
+if(CREATE_RPM_FOR_UBUNTU)
--- End diff --
The comment makes it sound as if setting -DCREATE_RPM_FOR_UBUNTU would
build both .rpm and .deb while not setting it "only" builds .deb.
But looking at the code itself, only one or the other is built but never
both. Assuming this is intentional, I would suggest removing "only" from the
comment for clarity.
---
[GitHub] madlib pull request #314: Ubuntu support: Enable creation of gppkg on Ubuntu
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/314 Ubuntu support: Enable creation of gppkg on Ubuntu This commit makes necessary changes to create a gppkg on Ubuntu. The default behavior when MADlib is built on Ubuntu is to create a .deb installer. If we want to create a gppkg, then we need an RPM due to limitations in gppkg. We now create an RPM on Ubuntu (assuming package alien is installed on Ubuntu) if the right cmake flag is specified. Once an RPM is created on `make package`, we can now go ahead and create the gppkg using `make gppkg`. The cmake flag to use if we want to create an .rpm instead of .deb on Ubuntu when we run `make package` is: -DCREATE_RPM_FOR_UBUNTU=True Co-authored-by: Orhan Kislal You can merge this pull request into a Git repository by running: $ git pull https://github.com/madlib/madlib ubuntu-gppkg-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/madlib/pull/314.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #314 commit bd85bae33473e697d7c26fdac9ee3253ff9a82b3 Author: Nandish Jayaram Date: 2018-08-06T22:19:18Z Ubuntu support: Enable creation of gppkg on Ubuntu This commit makes necessary changes to create a gppkg on Ubuntu. The default behavior when MADlib is built on Ubuntu is to create a .deb installer. If we want to create a gppkg, then we need an RPM due to limitations in gppkg. We now create an RPM on Ubuntu (assuming package alien is installed on Ubuntu) if the right cmake flag is specified. Once an RPM is created on `make package`, we can now go ahead and create the gppkg using `make gppkg`. The cmake flag to use if we want to create an .rpm instead of .deb on Ubuntu when we run `make package` is: -DCREATE_RPM_FOR_UBUNTU=True Co-authored-by: Orhan Kislal ---
