Re: [GitHub] incubator-madlib pull request #80: KNN Added

Hi NJ, Thanks for your inputs! I have created a PR after I made some suggested changes in the existing KNN code. Regards, Auon From: Nandish Jayaram Sent: Monday, December 19, 2016 12:58:59 PM To: dev@madlib.incubator.apache.org

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

GitHub user auonhaidar opened a pull request: https://github.com/apache/incubator-madlib/pull/81 JIRA: MADLIB-927 Changes made in KNN-help message-test cases-etc KNN Added Usage: select * from madlib.knn() select * from madlib.knn('help') select * from

Re: [GitHub] incubator-madlib issue #80: KNN Added

Sure! I would be happy to contribute. Please let me know how can I help with the writeup. I mostly started off by reading Madlib research papers. Then, I visited its website to understand its architecture in detail and to gauge how much do I have to learn in order to contribute to it. I know

[GitHub] incubator-madlib pull request #78: Graph: SSSP

Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/78#discussion_r93107178 --- Diff: src/ports/postgres/modules/graph/sssp.py_in --- @@ -0,0 +1,372 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] incubator-madlib issue #78: Graph: SSSP

Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/78 Yes that is the idea. I don't bother checking an edge unless its source vertex has been updated in the last pass. --- If your project is set up for it, you can reply to this email and

Re: [GitHub] incubator-madlib pull request #80: KNN Added

Hi Auon, You don't have to add the JIRA, it is already there: https://issues.apache.org/jira/browse/MADLIB-927 It's just good practice to mention the JIRA ID (JIRA: MADLIB-927) in your commit message. NJ On Sun, Dec 18, 2016 at 8:13 PM, Kazmi,Auon H wrote: > Hi NJ, > > I am

Re: [GitHub] incubator-madlib issue #80: KNN Added

Thank you Chenliang, I think it's a great idea to have such a writeup. It will be great if the community can suggest some topics to include in the writeup. Auon, you might be able to suggest some good ideas for the topics since you just went through the process and you would know where you

Re: [GitHub] incubator-madlib issue #80: KNN Added

Great! Let us know if you have any other questions. NJ On Fri, Dec 16, 2016 at 10:52 PM, Kazmi,Auon H wrote: > Hi NJ, > > I guess I was able to play around with branching and other stuff but my PR > got deleted from madlib's repo. But that's okay as I have got the comments >