[GitHub] incubator-madlib issue #174: Change test_train_split to train_test_split

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/174 k, thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib issue #174: Change test_train_split to train_test_split

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/174 Thanks for this small but important change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-madlib-site issue #8: MLP demo

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib-site/pull/8 This is a really great demo workbook, thanks for posting. Suggestions 1) concat does not work for greenplum, perhaps do: SELECT round(count(*)*100

[GitHub] incubator-madlib issue #169: MLP: Doc Fix

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/169 the user docs part of this PR LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-madlib issue #167: Update RELEASE_NOTES for v1.12 release

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/167 Here are some suggested changes/additions: 1) Change release date to Fri Aug 18 which might be a better estimate. 2) MLP Change New Module: Multilayer

[GitHub] incubator-madlib pull request #150: misc doc changes, mostly graph related

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/150 misc doc changes, mostly graph related You can merge this pull request into a Git repository by running: $ git pull https://github.com/fmcquillan99/incubator-madlib doc

[GitHub] incubator-madlib-site issue #7: MADLIB-1108. Fix issues with the download pa...

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib-site/pull/7 Checked new download from this PR for format and checked that new download links work for current and previous ASF incubating releases. ![image](https

[GitHub] incubator-madlib issue #120: DT: Assign memory only for reachable nodes

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/120 That's informative, thanks for posting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-madlib issue #123: MADLIB-1076. Review LICENSE file and README.md

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/123 In file ReadMe_Build.txt the lines 38-40 should be updated from + PostgreSQL 9.2, 9.3, 9.4 + HAWQ 1.2, 1.3 + Greenplum 4.2, 4.3

[GitHub] incubator-madlib issue #123: MADLIB-1076. Review LICENSE file and README.md

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/123 Looks good, thanks for the PR. One double check: the LICENSE file you are proposing refers explicitly to libstemmer, useLatex and pyyaml, but does not call out other 3rd

[GitHub] incubator-madlib pull request #122: Update README.md

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/122 Update README.md Updated 3rd party components list + a few minor edits You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n...

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/117 Ivan, the docs get updated when the release GA's. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-madlib issue #101: Multiple: Add casting to allow compilation with...

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/101 Holding this for now for a bit more investigation, so won't merge just yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-madlib pull request #118: misc doc changes for 1dot11

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/118 misc doc changes for 1dot11 mad changes to elastic net decision tree random forrest pivot You can merge this pull request into a Git repository by running

[GitHub] incubator-madlib issue #93: Allow encode_categorical_variables() to use the ...

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/93 Yes that sounds good. So `output_type` will be text I assume. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-madlib issue #93: Allow encode_categorical_variables() to use the ...

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/93 Thank you for the PR. It seems you would like to always output an svec for this function? i.e., not support regular array output? This seems overly restrictive. Most

[GitHub] incubator-madlib pull request #92: User docs updates

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/92 User docs updates Misc doc updates for v1dot 10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/fmcquillan99/incubator-madlib dt

[GitHub] incubator-madlib pull request #85: add examples for cross validation, and ge...

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/85 add examples for cross validation, and general edit of user doc General edit of elastic net user docs. And added some cross validation examples. You can merge this pull request

[GitHub] incubator-madlib issue #76: Include boost::format in MathToolkit_impl.hpp.

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/76 Thanks for the PR. Part of: Support for PostgreSQL 9.6 on all supported platforms incl macOS Sierra https://issues.apache.org/jira/browse/MADLIB-1046 --- If your project

[GitHub] incubator-madlib pull request #73: assoc rules doc updates

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/73 assoc rules doc updates Updated assoc rules docs and added filtering example You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-madlib pull request #72: Pca 1dot10 edits

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/72 Pca 1dot10 edits update docs and add more examples for pca train and projection You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-madlib pull request #71: update pca docs

Github user fmcquillan99 closed the pull request at: https://github.com/apache/incubator-madlib/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib pull request #71: update pca docs

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/71 update pca docs doc updates for PCA esp clarify use of sparse matrices and add more examples You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-madlib pull request #:

Github user fmcquillan99 commented on the pull request: https://github.com/apache/incubator-madlib/commit/d62bfbe5234d9e0185cd8acda711fe6dabfd7574#commitcomment-19326945 Thanks for the clarification. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-madlib pull request #:

Github user fmcquillan99 commented on the pull request: https://github.com/apache/incubator-madlib/commit/d62bfbe5234d9e0185cd8acda711fe6dabfd7574#commitcomment-19326786 I guess my question is: do we need to check the max allowable vocab size X num topics matrix size

[GitHub] incubator-madlib-site pull request #6: clarify dmg for pg on download page

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib-site/pull/6 clarify dmg for pg on download page minor download page clarification. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-madlib-site issue #4: Website 1dot9dot1

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib-site/pull/4 Xiaochang cherry picked the commit I needed and merged it. So closing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-madlib-site pull request #4: Website 1dot9dot1

Github user fmcquillan99 closed the pull request at: https://github.com/apache/incubator-madlib-site/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib pull request #67: misc doc changes for 1dot9dot1

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/67 misc doc changes for 1dot9dot1 Changes a number of user docs for clarity: modified: ../doc/mainpage.dox.in modified: ../src/ports/postgres/modules/pmml

[GitHub] incubator-madlib issue #63: Release v1.9.1: Add release notes

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/63 I would suggest you also add the class_weight to the SVM part of the release notes, since that is new too. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-madlib issue #60: Path: Proposed fix for JIRA MADLIB-1012

Github user fmcquillan99 commented on the issue: https://github.com/apache/incubator-madlib/pull/60 I guess the wider question is are we supporting standard postgres identifiers for symbols? https://www.postgresql.org/docs/8.2/static/plpgsql-statements.html So far I

[GitHub] incubator-madlib pull request: Feature: Sessionize funtion

Github user fmcquillan99 commented on the pull request: https://github.com/apache/incubator-madlib/pull/44 Here are the follow on JIRAs on sessionization from product mgmt perspective. Others can chip in on performance and implementation issues, and open other JIRAs as required

[GitHub] incubator-madlib pull request: Fix to disable the redirect URL for...

Github user fmcquillan99 commented on the pull request: https://github.com/apache/incubator-madlib/pull/40#issuecomment-208657382 Thanks for catching this snaga! We did a DNS change on Friday that broke the make. But we have re-verted that change so the make should work OK now

[GitHub] incubator-madlib pull request: misc doc changes for 1 dot 9

Github user fmcquillan99 commented on the pull request: https://github.com/apache/incubator-madlib/pull/33#issuecomment-201618779 thanks for review. I made the suggested changes --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-madlib pull request: misc doc changes for 1 dot 9

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/33 misc doc changes for 1 dot 9 https://issues.apache.org/jira/browse/MADLIB-982 1) Front page of user docs has links to madlib.net and some broken links mainpage.dox.in

[GitHub] incubator-madlib pull request: fix hypothesis test docs and exampl...

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/23 fix hypothesis test docs and examples related to https://issues.apache.org/jira/browse/MADLIB-895 Chi-squared independence test docs and examples had some mistakes

[GitHub] incubator-madlib pull request: Doc updates for SVM

GitHub user fmcquillan99 opened a pull request: https://github.com/apache/incubator-madlib/pull/19 Doc updates for SVM You can merge this pull request into a Git repository by running: $ git pull https://github.com/fmcquillan99/incubator-madlib svm-docs Alternatively you can