Re: MADlib Code coverage

2017-07-15 Thread Ed Espino
Nandish, For a very basic code coverage implementation using cmake, I have created: * JIRA: https://issues.apache.org/jira/browse/MADLIB-1138 * PR: https://github.com/apache/incubator-madlib/pull/151 This is a basic code coverage implementation runs on my mac using the following and a brew

Re: MADlib Code coverage

2017-07-14 Thread Ed Espino
Sure NJ, I'll create both (Jira and PR). -=e On Fri, Jul 14, 2017 at 1:46 PM, Nandish Jayaram wrote: > Thank you Ed, this is great. We will create a JIRA to incorporate this > (including documenting the steps to use it). Or, you can also create a PR. > :) > > NJ > > On

Re: MADlib Code coverage

2017-07-14 Thread Nandish Jayaram
Thank you Ed, this is great. We will create a JIRA to incorporate this (including documenting the steps to use it). Or, you can also create a PR. :) NJ On Fri, Jul 14, 2017 at 12:31 PM, Ed Espino wrote: > NJ, > > I spent about an hour getting it setup on my mac. This

Re: MADlib Code coverage

2017-07-14 Thread Ed Espino
NJ, I spent about an hour getting it setup on my mac. This supported the MLP PR review. I threw some info together below. Hope it helps, -=e -- Add lcov through brew (brings in lcov and genhtml utilities): brew install lcov "Total HACK" to add code coverage support into the

Re: MADlib Code coverage

2017-07-14 Thread Nandish Jayaram
Hi Ed, We haven't set that up for MADlib yet, but we will be looking into it soon. Any ideas? NJ On Fri, Jul 14, 2017 at 10:00 AM, Ed Espino wrote: > Out of curiosity, do MADlib developers regularly use code coverage > utilities to measure the coverage quality of their

MADlib Code coverage

2017-07-14 Thread Ed Espino
Out of curiosity, do MADlib developers regularly use code coverage utilities to measure the coverage quality of their tests? -=e -- *Ed Espino*