+1
Em qua, 29 de mai de 2019 às 15:31, Wei Chen escreveu:
> Got to agree with Taka.
> I admit that I merged it too quickly because I want to modify the Scala
> package name.
> I will just revert the history of those unchanged files together with
> PR#24.
> But keep the history of those files
Got to agree with Taka.
I admit that I merged it too quickly because I want to modify the Scala
package name.
I will just revert the history of those unchanged files together with PR#24.
But keep the history of those files with actual changes.
Does that sound fair to you Taka?
Best Regards
Wei
Hi,
I believe we should revert the PR#21 instead of just rename the files back.
It doesn't make sense to me, once in the previous PR#21 he changed 91 files
and now he is changing back 90 to the original version. This will generate
180 fake changes in our repository. It is much easier and clean if
Hello Lucas,
PR merged, please feel free to submit a new PR for executor rename.
Best Regards
Wei
On Wed, May 29, 2019 at 12:24 AM Wei Chen wrote:
> Cool!
> Just a quick note to everyone:
> https://github.com/apache/incubator-marvin/pull/23
> Keep the changes for Docker R Init.
> This should
Cool!
Just a quick note to everyone:
https://github.com/apache/incubator-marvin/pull/23
Keep the changes for Docker R Init.
This should make things easier.
Best Regards
Wei
On Wed, May 29, 2019 at 12:15 AM Lucas Bonatto Miguel
wrote:
> Sorry for the delay on that. This PR reverts the name
Sorry for the delay on that. This PR reverts the name changes to give a new
opportunity to the community to discuss what's the name that the module
executor should have in the new architecture.
https://issues.apache.org/jira/browse/MARVIN-48
Regards,
Lucas
On Wed, May 29, 2019 at 1:50 AM Wei
Hello Lucas,
Can you help to raise the revert PR for PR#21?
And please help to submit 2 new PRs for Docker R Init and Engine Rename
again.
We can merge the Docker R Init PR asap.
Best Regards
Wei
