[GitHub] maven-surefire pull request: Create better report for AssumptionFa...

2015-01-20 Thread jimma
GitHub user jimma opened a pull request: https://github.com/apache/maven-surefire/pull/81 Create better report for AssumptionFailure You can merge this pull request into a Git repository by running: $ git pull https://github.com/jimma/maven-surefire master Alternatively you c

Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-20 Thread Andreas Gudian
Hi Norbert, Oh, I misses that one as well - our animal sniffer seems to put its nose only into the main classes. A new pull-request would be great. Am Dienstag, 20. Januar 2015 schrieb Norbert Wnuk : > Hi Andreas, > The JDK API level is not enforced during build so that my accidental usage > of

Re: problem with AAR dependency

2015-01-20 Thread William Ferguson
Been thinking about this a little more. The TLDR version: I am suggesting that we provide more information and place a stricter syntax requirement of the POM *generated* by the build. This allows the generated POM to be a clear contract between the deployed artifact and it's consumers, regardless

Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-20 Thread Norbert Wnuk
Hi Andreas, The JDK API level is not enforced during build so that my accidental usage of JDK 1.7 API in tests was not discovered till recent Jenkins build: https://builds.apache.org/job/maven-surefire/1385/ Should I create new pull request / what is the procedure after closing original pull reques

Re: Maven Eclipse Java Formatter and Checkslyle

2015-01-20 Thread Hervé BOUTEMY
+1 if someone can fix this 120 limit Le mardi 20 janvier 2015 15:23:02 Igor Fedorenko a écrit : > I think we should. I also noticed the current formatter and checkstyle > disagree about explicit type parameters like in > > Collections.emptyList() this one is already fixed in http://svn.apach

Re: Maven Eclipse Java Formatter and Checkslyle

2015-01-20 Thread Kristian Rosenvold
Yes, we should fix the code style for this 2015-01-20 21:19 GMT+01:00 Dan Tran : > The current maven java formatter [1] keeps fluent statement in one line > with size larger than the limit 120 > > This case where I had to do a few manual hacks to make checkstyle happy for > PMD maven plugin > > Sh

Re: Maven Eclipse Java Formatter and Checkslyle

2015-01-20 Thread Igor Fedorenko
I think we should. I also noticed the current formatter and checkstyle disagree about explicit type parameters like in Collections.emptyList() I'd be happy to test the new formatter configuration. -- Regards, Igor On 2015-01-20 15:19, Dan Tran wrote: The current maven java formatter [1] k

Maven Eclipse Java Formatter and Checkslyle

2015-01-20 Thread Dan Tran
The current maven java formatter [1] keeps fluent statement in one line with size larger than the limit 120 This case where I had to do a few manual hacks to make checkstyle happy for PMD maven plugin Should we fix the formatter? Thanks -D [1] http://maven.apache.org/developers/maven-eclips

Re: [VOTE] Release Apache Maven Shared Component: Maven JarSigner Version 1.4

2015-01-20 Thread Hervé BOUTEMY
+1 Regards, Hervé Le dimanche 18 janvier 2015 10:46:12 Karl Heinz Marbaise a écrit : > Hi, > > We solved 4 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11761&version=198 > 64 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/issues/?jql=pro

Re: [VOTE] Release Apache Maven Shared Component: Maven Dependency Analyzer Version 1.6

2015-01-20 Thread Hervé BOUTEMY
+1 Regards, Hervé Le dimanche 18 janvier 2015 15:34:35 Karl Heinz Marbaise a écrit : > Hi, > > We solved 3 issues: > https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11761&version=20 > 721 > > There are still a couple of issues left in JIRA: > https://jira.codehaus.org/browse/MSHARE

Re: [VOTE] Release Apache Maven Shared Component: Maven Dependency Analyzer Version 1.6

2015-01-20 Thread Karl Heinz Marbaise
So here my +1 one binding VOTE is missing ;-).. On 1/18/15 3:34 PM, Karl Heinz Marbaise wrote: Hi, We solved 3 issues: https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11761&version=20721 There are still a couple of issues left in JIRA: https://jira.codehaus.org/browse/MSHARED/com

Re: [VOTE] Release Apache Maven Shared Component: Maven JarSigner Version 1.4

2015-01-20 Thread Benson Margulies
+1 binding On Tue, Jan 20, 2015 at 1:54 PM, Karl Heinz Marbaise wrote: > Hi, > > here is my +1 VOTE > > someone else? > > Kind regards > Karl Heinz Marbaise > On 1/18/15 10:46 AM, Karl Heinz Marbaise wrote: >> >> Hi, >> >> We solved 4 issues: >> >> http://jira.codehaus.org/secure/ReleaseNote.jspa

Re: [VOTE] Release Apache Maven Shared Component: Maven JarSigner Version 1.4

2015-01-20 Thread Karl Heinz Marbaise
Hi, here is my +1 VOTE someone else? Kind regards Karl Heinz Marbaise On 1/18/15 10:46 AM, Karl Heinz Marbaise wrote: Hi, We solved 4 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11761&version=19864 There are still a couple of issues left in JIRA: http://jira.codehaus.

[GitHub] maven-surefire pull request: SUREFIRE-1136 Current working directo...

2015-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Creating a patch for maven-pmd-plugin

2015-01-20 Thread twilliamson32
I'm not feeling that adventurous today. :) I've installed SVN and created the patch using that - for some reason the patch includes a bunch of whitespace changes, but unless someone objects it should be fine as-is. The project should compile error free (including tests) after the patch is ap

Re: Creating a patch for maven-pmd-plugin

2015-01-20 Thread Kristian Rosenvold
As Anders says, svn patch is official. There is an "authorative" git clone of the plugins repo that you can use at https://github.com/apache/maven-plugins . If you're feeling adventurous you can also make a pull request at github and reference this from your JIRA. This may work :) Kirstian 2015-

Re: Creating a patch for maven-pmd-plugin

2015-01-20 Thread Anders Hammar
An svn patch is the preferred way for a plugin hosted in svn. http://maven.apache.org/guides/development/guide-maven-development.html /Anders On Tue, Jan 20, 2015 at 4:12 PM, wrote: > This may or may not be a "stupid question", but it's new territory for me > so I thought I would ask: > > I nor

Creating a patch for maven-pmd-plugin

2015-01-20 Thread twilliamson32
This may or may not be a "stupid question", but it's new territory for me so I thought I would ask: I normally use Git for source control, so when I updated the maven-pmd-plugin project, I just downloaded the source .zip file into a new Git repo and made my changes. Now I need to create a patc