Github user ptahchiev closed the pull request at:
https://github.com/apache/maven-archetype/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
I think Robert was talking about the additional change in [1] and unit test
is a good candidate for this particular npe, since it's basically a
programming error. Better to catch it early on.
I've added a test to the PR for the overall LifecyclePhase class
functionality which would also prevent
ok, so both comments were right, we need to:
- add unit tests whenever makes sense
- add plugins trunks built with Maven core HEAD in our Jenkins setup
the more eyes, the more good enhancement ideas :)
Regards,
Hervé
- Mail original -
De: Anton Tanasenko atg.sleepl...@gmail.com
À:
yes, currently we consider only core ITs as core ITs [1]: but plugins trunks
are good core ITs candidates too :)
Regards,
Hervé
[1] https://builds.apache.org/view/M-R/view/Maven%20Core%20ITs/
- Mail original -
De: Jason van Zyl ja...@takari.io
À: Maven Developers List
Github user mfriedenhagen commented on the pull request:
https://github.com/apache/maven/pull/62#issuecomment-127376555
Hello,.just out of curiosity: why did you use the old junit3 mechanism?
---
If your project is set up for it, you can reply to this email and have your
reply appear
... about the additional change in [1] and unit test is a good candidate
for this particular npe...
Exactly my point. In general a lot of NPE's could have been discovered
with proper unittesting.
thanks,
Robert
Op Mon, 03 Aug 2015 11:30:21 +0200 schreef Anton Tanasenko
Github user atanasenko commented on the pull request:
https://github.com/apache/maven/pull/62#issuecomment-127380233
Hi, I took a look at a couple of neighboring tests and was convinced all of
them are junit3
---
If your project is set up for it, you can reply to this email and have
Github user atanasenko commented on the pull request:
https://github.com/apache/maven/pull/62#issuecomment-127386965
I've updated to junit4, looks more modern now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
