[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-14 Thread rpatrick00
Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Because the maven shell scripts are finding the .mvn directory before starting java in order to find the relevant .mvn/jvm.config to process any java command-line options that may be found in it. T

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-14 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/maven/pull/93 I wonder, whether this couldn't be handled at the Java level? If so, there would be no need to change script files, making them even more complex than they already are. --- If your project is set up

[GitHub] maven-surefire issue #119: Make JUnit4VersionsIT acutally use the versions s...

2016-09-14 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/119 @Tibor17 I don't have commit access to the maven repositories. You will have to merge it for me :-) --- If your project is set up for it, you can reply to this email and have your reply appe

MNG-5889 fix

2016-09-14 Thread Robert Patrick
Can someone please take a look at my pull request (https://github.com/apache/maven/pull/93) for https://issues.apache.org/jira/browse/MNG-5889? Thanks, Robert

[GitHub] maven-surefire issue #119: Make JUnit4VersionsIT acutally use the versions s...

2016-09-14 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/119 @britter Sure, go 4 it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] maven-surefire pull request #120: Add convinient method to check for the cur...

2016-09-14 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/120#discussion_r78776416 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java --- @@ -159,4 +164,10 @@ public static

[GitHub] maven-surefire pull request #120: Add convinient method to check for the cur...

2016-09-14 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/120#discussion_r78775898 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java --- @@ -159,4 +164,10 @@ public static

[GitHub] maven-surefire issue #119: Make JUnit4VersionsIT acutally use the versions s...

2016-09-14 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/119 @Tibor17 can we merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: New warnings with Maven 3.4-SNAP

2016-09-14 Thread Christian Schulte
Am 09/14/16 um 13:50 schrieb Stephane Nicoll: > Dependency 'org.springframework.cloud:spring-cloud-commons:jar' has > conflicting dependency management from ' > org.springframework.cloud:spring-cloud-consul-dependencies:1.0.2.RELEASE' and > 'org.springframework.cloud:spring-cloud-commons-dependenci

Re: New warnings with Maven 3.4-SNAP

2016-09-14 Thread Christian Schulte
Am 09/14/16 um 14:17 schrieb Christian Schulte: > Am 09/14/16 um 13:50 schrieb Stephane Nicoll: >> Well, first of all I have no idea what the following means: >> >> rearrange the causing imports in the inheritance hierarchy to apply >> standard override logic based on artifact coordinates. > > App

Re: New warnings with Maven 3.4-SNAP

2016-09-14 Thread Christian Schulte
Am 09/14/16 um 13:50 schrieb Stephane Nicoll: > Well, first of all I have no idea what the following means: > > rearrange the causing imports in the inheritance hierarchy to apply > standard override logic based on artifact coordinates. Apply inheritance override logic to resolve the conflict. Yo

Re: New warnings with Maven 3.4-SNAP

2016-09-14 Thread jieryn
Hi, I don't think we agree at all on most of this stuff, fine, I won't press it. However... On Wed, Sep 14, 2016 at 2:42 AM, Stephane Nicoll wrote: > First of all, I'd like the error message to change. I still don't know to > this day what it means. Second, if Maven is able to find out that two

Re: New warnings with Maven 3.4-SNAP

2016-09-14 Thread Stephane Nicoll
On Wed, Sep 14, 2016 at 1:32 PM, Christian Schulte wrote: > Am 09/14/16 um 08:42 schrieb Stephane Nicoll: > > First of all, I'd like the error message to change. I still don't know to > > this day what it means. Second, if Maven is able to find out that two > boms > > provide dependency managemen

Re: New warnings with Maven 3.4-SNAP

2016-09-14 Thread Christian Schulte
Am 09/14/16 um 08:42 schrieb Stephane Nicoll: > First of all, I'd like the error message to change. I still don't know to > this day what it means. Second, if Maven is able to find out that two boms > provide dependency management for foo with conflicting versions, It would > be nice to say in whic

AW: Making Maven extendable for non standard scopes

2016-09-14 Thread Christofer Dutz
Hi Robert, Well I guess MPLUGIN-302 is about extending Maven to allow easy injection of dependencies of a given scope into a plugin. This would help use scopes in plugins. But I didn't interpret it as dealing with extending Maven to support other scopes in general. The way I understood it, it