Re: [MNG-6084] Support JSR 250 annotations

Thanks Michael for pushing this out. Looking forward to use it in 3.5.1 -D On Wed, May 24, 2017 at 4:04 PM, Michael Osipov wrote: > Who seconds MNG-6084 for 3.5.1? > > This one was developed by Dan Tran. I added non-functional fixes to it. > All ITs pass as well as its own

Re: convert maven-resolver-provider to jsr330

Yes please, thank you :-] —jason On May 24, 2017 at 2:38:24 PM, Igor Fedorenko (i...@ifedorenko.com) wrote: I'd like to ask for somebody to second my change described in [MNG-6233]. The change cleans up mixture of jsr330 and plexus annotations used in maven-resolver-provider, leaving only

Re: convert maven-resolver-provider to jsr330

+1 On 25 May 2017 at 07:41, Manfred Moser wrote: > Lgtm +1 > > Igor Fedorenko wrote on 2017-05-24 14:38: > > > I'd like to ask for somebody to second my change described in > > [MNG-6233]. The change cleans up mixture of jsr330 and plexus > > annotations used in

[MNG-6084] Support JSR 250 annotations

Who seconds MNG-6084 for 3.5.1? This one was developed by Dan Tran. I added non-functional fixes to it. All ITs pass as well as its own IT. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 @jdillon Igor merged his PR contained your fix. This PR is obsolete now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: convert maven-resolver-provider to jsr330

Lgtm +1 Igor Fedorenko wrote on 2017-05-24 14:38: > I'd like to ask for somebody to second my change described in > [MNG-6233]. The change cleans up mixture of jsr330 and plexus > annotations used in maven-resolver-provider, leaving only jsr330. The > change is small and I believe safe, does not

convert maven-resolver-provider to jsr330

I'd like to ask for somebody to second my change described in [MNG-6233]. The change cleans up mixture of jsr330 and plexus annotations used in maven-resolver-provider, leaving only jsr330. The change is small and I believe safe, does not change any user-observable behaviour during normal maven

[GitHub] maven-surefire issue #149: Add a doctype to the StatelessXmlReporter output

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/149 DOCTYPE is old. Do you mean report XML e.g. `surefire-reports/TEST-MyTest.xml`? ``` http://www.w3.org/2001/XMLSchema-instance;

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 Thanks for the explanation. So it is not a prerequisite directly. I'd still insist for an JIRA because I need another committer to second this and have this in our release notes. Do you have a

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor's change is the more correct/ideal change to avoid future mismatch between plexus-annotation configuration and JSR-330 annotations. The problem is that plexus @Requirement injects directly to

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 Just to be clear, Igor's change is s prerequisite to your issue? If so, we need two tickets. The IT assures that nothing will break your fix -- no more, no less. --- If your project is set up

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor already created https://issues.apache.org/jira/browse/MNG-6233 but if you really need another issue I can file one just to fix this specific problem. Seems a bit odd though that you want

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 @jdillon I'd like to merge this but need a JIRA issue. At best, an IT too. Can you provide a simple one? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Hey folks can we get some movement on this and/or https://github.com/apache/maven/compare/MNG-6233_maven-resolver-provider-jsr330 ATM its broken, either of these fixes the issue. --- If

Inject Maven parameters to Plexus components

Is it possible to Inject Maven paramaters into Plexus components I've tried this without success. Both repoSession and repositories are null @Component(role = ResolverComponent.class, instantiationStrategy = "per-lookup") public class ResolverComponent { @Requirement private Logger