Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

2017-07-28 Thread Peter Ansell
Upgrading to the latest Mockito 2.x version has been enough in my other projects to eliminate its Java-9 warnings/errors without any code changes, but YMMV. Cheers, Peter On 29 July 2017 at 07:44, Karl Heinz Marbaise wrote: > Hi, > > +1 from me. > > > Tested with JDK 9+180

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

2017-07-28 Thread carlspring
Github user carlspring commented on a diff in the pull request: https://github.com/apache/maven-indexer/pull/17#discussion_r130204917 --- Diff: indexer-core/pom.xml --- @@ -84,21 +84,25 @@ under the License. org.apache.lucene lucene-core +

[GitHub] maven-surefire issue #159: SUREFIRE-1391: Eliminate redundant call in calcul...

2017-07-28 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/159 @andrew-j-cohen thx, merged. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-surefire issue #158: Fix typo in docs

2017-07-28 Thread StephenKing
Github user StephenKing commented on the issue: https://github.com/apache/maven-surefire/pull/158 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-surefire pull request #158: Fix typo in docs

2017-07-28 Thread StephenKing
Github user StephenKing closed the pull request at: https://github.com/apache/maven-surefire/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #158: Fix typo in docs

2017-07-28 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/158 @StephenKing Thx, this PR was pushed to master and can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

2017-07-28 Thread Manfred Moser
Wow Karl! Very nice testing effort. +1 from me (with less testing but still some ubuntu and osx based runs..) Manfred Karl Heinz Marbaise wrote on 2017-07-28 14:44: > Hi, > > +1 from me. > > > Tested with JDK 9+180 the following Maven versions: > o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5,

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

2017-07-28 Thread Karl Heinz Marbaise
Hi, +1 from me. Tested with JDK 9+180 the following Maven versions: o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5 Tested with JDK 1.8.0_144 the following Maven versions: o Maven 3.5.0, Maven 3.3.9, Maven 3.2.5, Maven 3.1.1, Maven 3.0.5 Tested with JDK 1.8.0_131, Maven

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

2017-07-28 Thread Peter Ansell
Yes, +1 On 28 July 2017 at 18:18, Robert Scholte wrote: > Thanks for testing. Can I translate this to a +1 vote? > > Robert > > > On Fri, 28 Jul 2017 02:04:40 +0200, Peter Ansell > wrote: > >> The sha1 matches for me and the plugin (including

[GitHub] maven-surefire issue #160: SUREFIRE-1398 threadCount is set for JUnit only w...

2017-07-28 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/160 @MatousJobanek It should be sanity check and Mojo should fail if `threadCount` is <= 0 && isApplicable. IsApplicable is TRUE if `forkMode` is "pertest" OR `parallel` is any of

MNG-6174 for Maven 3.5.1

2017-07-28 Thread Karl Heinz Marbaise
Hi, I would like to integrate MNG-6174[1] into Maven 3.5.1 (master).. The IT's are fine see[2] Are any objections? If there are no objections I would like to merge to master on tuesday... Kind regards Karl Heinz Marbaise [1]: https://issues.apache.org/jira/browse/MNG-6174 [2]:

MNG-6123 for Maven 3.5.1

2017-07-28 Thread Karl Heinz Marbaise
Hi, I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which needs a small change to one of the integration tests[2] The IT's are fine see[3] Are any objections? If there are no objections I would like to merge to master on tuesday... Kind regards Karl Heinz Marbaise [1]:

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

2017-07-28 Thread scela
Github user scela commented on a diff in the pull request: https://github.com/apache/maven-indexer/pull/17#discussion_r130105466 --- Diff: indexer-core/pom.xml --- @@ -84,21 +84,25 @@ under the License. org.apache.lucene lucene-core + 6.1.0

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

2017-07-28 Thread carlspring
Github user carlspring commented on a diff in the pull request: https://github.com/apache/maven-indexer/pull/17#discussion_r130101051 --- Diff: indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java --- @@ -0,0 +1,19 @@ +package org.apache.maven.index; +

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

2017-07-28 Thread scela
Github user scela commented on a diff in the pull request: https://github.com/apache/maven-indexer/pull/17#discussion_r130093790 --- Diff: indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java --- @@ -0,0 +1,19 @@ +package org.apache.maven.index; +

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

2017-07-28 Thread scela
Github user scela commented on the issue: https://github.com/apache/maven-indexer/pull/17 https://issues.apache.org/jira/browse/MINDEXER-104 Done On Fri, Jul 28, 2017 at 3:43 PM, Martin Todorov wrote: > @scela

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

2017-07-28 Thread carlspring
Github user carlspring commented on the issue: https://github.com/apache/maven-indexer/pull/17 @scela , You can file a new issue under [MINDEXER](https://issues.apache.org/jira/browse/MINDEXER) Jira. Cheers, Martin --- If your project is set up for it,

Re: Any feedback for MNG-6261?

2017-07-28 Thread Robert Scholte
Nice catch. Looks a lot like MNG-6262 On Fri, 28 Jul 2017 14:12:19 +0200, Dawid Weiss wrote: IIUC the failing project isn't always failing. This could be an explanation. I didn't say it isn't always failing -- I said it is failing deterministically (as in: always)

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

2017-07-28 Thread scela
Github user scela commented on the issue: https://github.com/apache/maven-indexer/pull/17 Sure. Can you point me where the Jira project is hosted? Lucene usually makes major changes so I suspect going to 6.6 would be much more work. I'd prefer to move to 6.1 first and then

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

2017-07-28 Thread carlspring
Github user carlspring commented on the issue: https://github.com/apache/maven-indexer/pull/17 The changes, (despite my minor remarks), look good! Thanks for this pull! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

2017-07-28 Thread carlspring
Github user carlspring commented on a diff in the pull request: https://github.com/apache/maven-indexer/pull/17#discussion_r130087375 --- Diff: indexer-core/src/test/java/org/apache/maven/index/FullIndexNexusIndexerTest.java --- @@ -1,26 +1,8 @@ package

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

2017-07-28 Thread carlspring
Github user carlspring commented on a diff in the pull request: https://github.com/apache/maven-indexer/pull/17#discussion_r130086143 --- Diff: indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java --- @@ -0,0 +1,19 @@ +package org.apache.maven.index; +

[GitHub] maven-indexer pull request #17: Migration to Lucene 6.1.0

2017-07-28 Thread carlspring
Github user carlspring commented on a diff in the pull request: https://github.com/apache/maven-indexer/pull/17#discussion_r130085893 --- Diff: indexer-core/pom.xml --- @@ -84,21 +84,25 @@ under the License. org.apache.lucene lucene-core +

[GitHub] maven-indexer issue #17: Migration to Lucene 6.1.0

2017-07-28 Thread cstamas
Github user cstamas commented on the issue: https://github.com/apache/maven-indexer/pull/17 @olamy @scela sounds fine to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Any feedback for MNG-6261?

2017-07-28 Thread Dawid Weiss
> IIUC the failing project isn't always failing. This could be an explanation. I didn't say it isn't always failing -- I said it is failing deterministically (as in: always) from the same location, but sometimes isn't failing on the same project when executed from *another* location. I know what

Re: [VOTE] Apache Maven Compiler 3.6.2

2017-07-28 Thread Robert Scholte
+1 On Wed, 26 Jul 2017 01:44:01 +0200, Olivier Lamy wrote: Hi, I'd like to release Apache Maven Compiler Plugin version 3.6.2. We fixed 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317225=12339154 Staging repo:

Re: Any feedback for MNG-6261?

2017-07-28 Thread Robert Scholte
Well, file permission/access is indeed something to keep in mind. E.g. virusscanner are known to block access to a file for a short moment. IDEs can also cause issues. If some file/code changes causes background rebuild and you're doing an explicit Maven build yourself at the same time, you

Re: Any feedback for MNG-6261?

2017-07-28 Thread Dawid Weiss
Thanks, I'll dig and let you know if I can figure it out. (or not). Dawid > https://maven.apache.org/ref/3.5.0/maven-resolver-provider/ > This is the module responsible for resolving parents, dependencies, etc. > > https://github.com/apache/maven > Here it is at github > >> Adding -X doesn't

Re: Any feedback for MNG-6261?

2017-07-28 Thread Robert Scholte
On Fri, 28 Jul 2017 10:49:42 +0200, Dawid Weiss wrote: There must be a difference between the 2 projects. There is no difference. It's the same repo on the same commit, I called "git clean -xfd ." prior to executing those maven commands (and obviously there are no

Re: Any feedback for MNG-6261?

2017-07-28 Thread Dawid Weiss
> Have you double checked file permissions? if it can't read the parent > pom (maybe not all dirs are +x etc) then it wil have the behavior you > see Come on, guys. :) I wouldn't ask if I didn't try it in many multiple combinations. It is a heisenbug, but the reason for it is not a trivial

Re: Any feedback for MNG-6261?

2017-07-28 Thread Dawid Weiss
> There must be a difference between the 2 projects. There is no difference. It's the same repo on the same commit, I called "git clean -xfd ." prior to executing those maven commands (and obviously there are no other changes). > But as long as there's no attachment which reproduces the issue,

Re: Any feedback for MNG-6261?

2017-07-28 Thread Thomas Matthijs
Have you double checked file permissions? if it can't read the parent pom (maybe not all dirs are +x etc) then it wil have the behavior you see On Thu, Jul 27, 2017 at 10:07 PM, Dawid Weiss wrote: > I added a comment on that issue. The problem is not deterministic for >

Re: Any feedback for MNG-6261?

2017-07-28 Thread Robert Scholte
There must be a difference between the 2 projects. But as long as there's no attachment which reproduces the issue, we can't help. Ensure that you've seen the attached project fail. Just some suggestions to help: - rename the directory (for backup), do a fresh checkout and try to do it

Re: [VOTE] Release Apache Maven Enforcer Plugin version 3.0.0-M1

2017-07-28 Thread Robert Scholte
Thanks for testing. Can I translate this to a +1 vote? Robert On Fri, 28 Jul 2017 02:04:40 +0200, Peter Ansell wrote: The sha1 matches for me and the plugin (including requireJavaVersion) works under both Oracle JDK 8+u131 and Oracle JDK 9+177. Thanks, Peter On

[GitHub] maven-wagon pull request #34: Added FTP over HTTP proxy wagon

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-wagon/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is