Re: main-class + module-version

Hi Robert, Thank you for you comments. >> Also I took a look at the changes in the JDK jar tool and I notice a >> couple of things that it does: >> >> 1. The structure of the jar produced is such that the module info >> entries are placed after the manifest and before the rest of the >> files.

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Thx for contributing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...

Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

Github user jon-bell commented on the issue: https://github.com/apache/maven-surefire/pull/161 @Tibor17 I have rebased master on top of my branch, it is again up to date. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @JoelNGeorge @owenfarrell Pls let me run the build and next steps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] maven-surefire issue #159: SUREFIRE-1391: Eliminate redundant call in calcul...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/159 @andrew-j-cohen Please close this PR. It was already merged in Surefire project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: [GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

Check your branch if it is up to date with master. On Mon, Aug 28, 2017 at 11:51 PM, Tibor17 wrote: > Github user Tibor17 commented on the issue: > > https://github.com/apache/maven-surefire/pull/161 > > @jon-bell > Ok, now your IT passed. I will run whole test

[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Ok, now your IT passed. I will run whole test set now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/162 @britter Done. I added enforcer configuration. I hope it will be fine. Let me know if you have something to do for me. Sometimes I am without internet connection for several days

[GitHub] maven-surefire pull request #162: SUREFIRE-1384: ProviderInfo for JUnit Plat...

Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven issue #113: [MNG-6127] Fix plugin execution configuration interference

Github user mkrizmanic commented on the issue: https://github.com/apache/maven/pull/113 Merged to master: https://github.com/apache/maven/commit/f1ed6592b1c701834d1377fade6cdb382a63bbf4 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven pull request #113: [MNG-6127] Fix plugin execution configuration inter...

Github user mkrizmanic closed the pull request at: https://github.com/apache/maven/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Code review on SUREFIRE-1264_2

Hi All, I have pushed branch SUREFIRE-1264_2 which is bug fix for Jira SUREFIRE-1264. I have announced our user on Jira and asked him to test this fix in his project. -- Cheers Tibor

Re: [GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

I will have a look. On Mon, Aug 28, 2017 at 8:49 PM, britter wrote: > Github user britter commented on the issue: > > https://github.com/apache/maven-surefire/pull/162 > > @Tibor17 any news on this? > > > --- > If your project is set up for it, you can reply to this

[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...

Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/162 @Tibor17 any news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: maven-jdeps-plugin and JDK9 - no love :(

My bad, I thought it was was the 23rd plugin to update. This is an easy fix. Should be able to do a release this week. Robert On Mon, 28 Aug 2017 13:13:03 +0200, Mark Derricutt wrote: On 28 Aug 2017, at 22:07, Robert Scholte wrote: Can you share these 23? Maybe worth

Re: maven-jdeps-plugin and JDK9 - no love :(

On 28 Aug 2017, at 22:07, Robert Scholte wrote: > Can you share these 23? Maybe worth sharing at  Ack - I was meaning to write 23 DAYS on the countdown ( at http://www.java9countdown.xyz/ ) Mark --- "The ease with which a change can be implemented has no

Re: maven-jdeps-plugin and JDK9 - no love :(

On Mon, 28 Aug 2017 09:03:40 +0200, Mark Derricutt wrote: On 28 Aug 2017, at 18:11, Enrico Olivelli wrote: Mark, IMHO It seems just a 'well known' problem of commons lang. Maybe just updating the dependency for the plugin in your pom may help. Sweet that worked - will go

Re: main-class + module-version

On Mon, 28 Aug 2017 07:32:36 +0200, Plamen Totev wrote: Hi, On Fri, Aug 25, 2017 at 6:57 PM, Robert Scholte wrote: I'm having a look at the JarArchiver of the plexus-archiver project as used by maven-jar-plugin. This archiver does some

Re: maven-jdeps-plugin and JDK9 - no love :(

On 28 Aug 2017, at 18:11, Enrico Olivelli wrote: > Mark, > IMHO It seems just a 'well known' problem of commons lang. Maybe just > updating the dependency for the plugin in your pom may help. Sweet that worked - will go raise a ticket about it so we can get a PR made and another release... 23

Re: maven-jdeps-plugin and JDK9 - no love :(

On lun 28 ago 2017, 07:49 Mark Derricutt wrote: > Hey all, > > Now that there's versions of enforcer/javadoc and co that work with java > 9, and error-prone now seems to work with java 9 - my builds have gotten as > far as running jdeps, which appears to not like java 9 at all