Hi Enrico,
The PR https://github.com/apache/maven-enforcer/pull/52 has been approved
(Thanks!) but not merged yet.
Is this something you can take care of, or should I take any action?
Regards,
Tomo
*From: *Tomo Suzuki
*Date: *Mon, Mar 18, 2019 at 12:15 AM
*To: *Maven Developers List
Enrico,
Thanks
I am able to reproduce the issue on a Windows box.
Still I can't understand why we aren't seeing problems on CI.
Eric,
do you have cycles to create a JIRA and send a Pull request ?
We can fix it in master.
As Tibor said, I think this is not a blocker for the 3.1.0 release.
Otherwise I
Il giorno mar 14 mag 2019 alle ore 14:34 Tibor Digana <
tibordig...@apache.org> ha scritto:
> Two files in one IT are problematic but I don't think it is a problem for
> your release.
> The CPD should be fixed and a method should be reused but again it is not
> a reason to interrupt the vote.
>
Since git settings may influence line separators when cloning and
Checkstyle seems to want read line separator to match System.lineSeparator,
maybe the test need to take full control back (from git) over the two files
in the test, to have a fully deterministic test input files.
- Eric L
On Tue,
Hi, I edited the wrong files before when I changed line breaks (edited
copies under target folder, silly me!). I changed the line separators to
Windows-style for the two files under MCHECKSTYLE-54 (Mcheckstyle54.java
and package.info) and the integration tests passes (expect for that other
I wrote both files again, see the attachments (windows and Unix EOL).
To be faster, I am running the command *mvn checkstyle:check* from the (IT
target) path on my system
c:\vcs\github\maven-checkstyle-plugin\target\it\MCHECKSTYLE-54\src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\
Two files in one IT are problematic but I don't think it is a problem for
your release.
The CPD should be fixed and a method should be reused but again it is not
a reason to interrupt the vote.
One more question. Why did you "git push" the history from Maven Release
plugin?
This should be done
I will get a windows box and try to reproduce.
It is weird that on ASF Jenkins the build is passing even on windows
Enrico
-- Forwarded message -
Da: Enrico Olivelli
Date: mar 14 mag 2019, 13:58
Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0
To: Maven
Eric and Tibor,
Thank you so much for your effort in testing Maven Checkstyle Plugin.
This is the "official" VOTE thread, here we have to decide if the staged
artifacts are good to be released or not.
Feel free to cast a -1 if you think that the staged artifacts are not
"stable" or there is any
Tried overriding line.separator when running using -Dline.separator="\n",
but then the builds fails (early) in maven-plugin-plugin:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor
(default-descriptor) on project maven-checkstyle-plugin: Execution
I tried bumping checkstyle to 8.20, plus a few of the plexus dependencies,
but that just brought an additional failure... (to
MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-)
I suppose the problem might be that the files has linux-style line breaks
(this is desired for me, I don't want to convert
I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I didn't try
the source zip, just cloned master)
I tested on one of our corporate laptops:
Windows 10
Cygwin 64-bit (I use it to clone the repo and use Maven)
Maven 3.6.0
Java 8 update 202
The build log says:
[INFO] There are 2 errors
Il lun 13 mag 2019, 23:48 Tibor Digana ha scritto:
> Robert, I did *not* use the source zip.
>
IMHO we should vote on the staged zip
> git clone https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin
> Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10
>
This is what CI does and tests are
13 matches
Mail list logo
