Re: Regression in model interpolation coming from using JSR-330?

2019-11-02 Thread Gabriel Belingueres
Thanks Stuart. The reproducibility PR you mention helps in having a deterministic ordering inside the Named components file to buld exactly the same executable, but it does not mean it is the right priority for component injection. Do you know if it is possible to configure sisu to throw an

Re: Regression in model interpolation coming from using JSR-330?

2019-11-02 Thread Stuart McCulloch
Yes, when there are multiple non-default implementations with the same priority then it will pick the first in the list (where the "list" in question is actually a combination of plugins + extensions + core bindings for the given type) If a particular implementation should be treated as the

Regression in model interpolation coming from using JSR-330?

2019-11-02 Thread Gabriel Belingueres
Hi: I just built maven core from source and found that it was using StringSearchModelInterpolator instead of StringVisitorModelInterpolator, a regression from the last 3.6.2 release. I found that in maven-model-builder/META-INF/sisu/javax.injected.Named file, both interpolators are listed but in

Re: [VOTE] Release Apache Maven Source Plugin version 3.2.0

2019-11-02 Thread Tibor Digana
+1 On Tue, Oct 29, 2019 at 10:44 PM Hervé BOUTEMY wrote: > Hi, > > We solved 2 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924&=12345522=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-1532/ > >

Re: [VOTE] Release Apache Maven Source Plugin version 3.2.0

2019-11-02 Thread Hervé BOUTEMY
ok, I found the root cause: you built on Windows using the official source distribution that I prepared on Linux then your result is half Linux line endings (for example the pom.xml that is copied into the jar), half Windows line endings (generated content like pom.properties) this proves that

Re: New link pattern when option is set to true

2019-11-02 Thread Enrico Olivelli
Hi Max. sorry for late reply. I think your idea is interesting and you work is valuable, You can follow up by creating a JIRA in issues.apache.org in MJAVADOC project and then you can also send a PR. Please add an integration test. this is the guide for new contributors

Re: [VOTE] Release Apache Maven Source Plugin version 3.2.0

2019-11-02 Thread herve . boutemy
uh, strange, the test for maven-assembly-plugin is even more aggressive than maven-source-plugin: the issue should not only happen here yes, I'm interested in the archive, with details on the OS used Regards, Hervé - Mail original - De: "Tibor Digana" À: "Maven Developers List" ,

Re: [VOTE] Release Apache Maven Assembly Plugin version 3.2.0

2019-11-02 Thread Tibor Digana
+1, - SHA512 ok, successful local and ASF build On Tue, Oct 29, 2019 at 11:10 PM Hervé BOUTEMY wrote: > Hi, > > We solved 9 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317220=12344773=Text > > Staging repo: >

Re: [VOTE] Release Apache Maven Source Plugin version 3.2.0

2019-11-02 Thread Tibor Digana
!!! ERROR !!! Local build failure. I can send the ZIP in Slack. [INFO] run post-build script verify.groovy [INFO] reproducible\pom.xml . FAILED (6.8 s) [INFO] The post-build script did not succeed. assert buf.startsWith( "reproducible-1.0-sources.jar sha1 =

Re: [VOTE] Release Apache Maven JAR Plugin version Y.Z

2019-11-02 Thread Tibor Digana
+1 - SHA512 ok, successful local and ASF build On Tue, Oct 29, 2019 at 11:06 PM Hervé BOUTEMY wrote: > Hi, > > We solved 1 issue: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526=12345503=Text > > Staging repo: >

Re: [VOTE] Release Apache Maven Assembly Plugin version 3.2.0

2019-11-02 Thread Enrico Olivelli
+1 (non binding) tested on windows + jdk 8 Enrico Il giorno ven 1 nov 2019 alle ore 14:37 Karl Heinz Marbaise < khmarba...@gmx.de> ha scritto: > Hi, > > tested. +1 from me. > > Kind regards > Karl Heinz Marbaise > > On 29.10.19 23:10, Hervé BOUTEMY wrote: > > Hi, > > > > We solved 9 issues: >

[RESULT] [VOTE] JDK 8 Minimum Requirement for Maven 3.7.0

2019-11-02 Thread Karl Heinz Marbaise
Hi, The vote has passed with the following result: +1 : Romain Manni-Bucau, Enrico Olivelli, Gary Gregory, Francois Papon, Olivier Lamy, Mickael Istria, Tamás Cservenák, Hervé BOUTEMY, Stephen Connolly, Manfred Moser, Anders Hammar, Gabriel Belingueres, Arnaud Héritier, Daniel Kulp, Stephane