Thank you Ben,
I will try to move forward a few pr today.
Enrico
Il ven 3 gen 2020, 08:10 Benjamin Marwell ha scritto:
> Dear list members,
>
> there are currently unmerged PRs for the checkstyle plugin:
> https://github.com/apache/maven-checkstyle-plugin/pulls
> Some of them seem to be
Dear list members,
there are currently unmerged PRs for the checkstyle plugin:
https://github.com/apache/maven-checkstyle-plugin/pulls
Some of them seem to be no-brainers (readme-/pom-url-/site-updates),
others have been discussed exhaustively.
How do I/we get them merged? I know that Robert
Yes, will go down this route.
Fun side note: that warning was so far mostly applied to the outputDirectory
part. But this is just the path INSIDE the zip. So most of the warnings have
been pretty much useless ;)
Will continue to work on this. Probably we might also extract the path handling
On 01/01/2020 00:50, Karl Heinz Marbaise wrote:
> But I don't understand why you are compiling parts of Maven into your JAR ?
Karl, my JAR (which provides an API that its users use in their Java apps) needs
to order version strings. Rather than write that myself, I would like to
efficiently embed
My notBlank code was actually correct. But I hadn't made clear that this code
wasn't replacing the whole notBlank method, but only its inner part, not
changing the quick initial test, which also tests for nulls:
private static void notBlank( String str, String message )
{
int c =
On 01/01/2020 01:13, Michael Osipov wrote:
> 2. In ArtifactUtils.notBlank, replacing
>>
>> Validate.notBlank( str, message );
>>
>> with
>>
>> for (int i=0; i < str.length(); i++) if
>> (!Character.isWhitespace(str.charAt(i))) return;
>> throw new
I'd prefer to switch to Path, and in this case use Path.resolve
You should add that to the test.
I agree that a path starting with "/" should be interpreted as an absolute
path, and AFAIK the warning is there already for ages so I don't mind changing
the behavior.
thanks,
Robert
On 1-1-2020
