Re: (anonymous) github user commits

2020-03-21 Thread Slawomir Jaranowski
Hi, If I can I want show to you some advantages/disadvantages as I see as collaborator to external project. Maybe some of them you will like. I've analyzed some commits what I did to maven-invoker-plugin project. I used: git log --graph --show-signature --format=full *1. commit made manually

Re: (anonymous) github user commits

2020-03-21 Thread Benjamin Marwell
Checkstyle builds will fail of there is more than one commit in a PR. Not saying I like it, but it's an option. On Sat, 21 Mar 2020, 16:17 Elliotte Rusty Harold, wrote: > So it appears that if I do all squashing and merging locally and then > push directly to master, I get listed as

Re: (anonymous) github user commits

2020-03-21 Thread Elliotte Rusty Harold
So it appears that if I do all squashing and merging locally and then push directly to master, I get listed as committer and author: https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git=commit=4264899a152a6205b0f34a32e9c947edcd9cb1e8 Github is no longer listed as the committer. This is

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

2020-03-21 Thread GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993340 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

2020-03-21 Thread GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993381 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

2020-03-21 Thread GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993498 ## File path:

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

2020-03-21 Thread GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993483 ## File path:

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

2020-03-21 Thread GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993426 ## File path:

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

2020-03-21 Thread GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993290 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

2020-03-21 Thread GitBox
elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993269 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java