Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Graham Leggett
On 25 Apr 2020, at 17:12, Robert Oxspring wrote: >> I tend to think it does not need any hash but just a lastUpdated >> track (the most recent file invalidating previous cache, it is enough and >> faster than any hash computation) > > I’m not totally sure of this. Filtering, for example, is

clean up branches

2020-04-25 Thread Robert Scholte
Hi all, we should clean up branches. Every time we touch the Jenkins File, all branches will be built. This can result a long queue in Jenkins. Especially https://builds.apache.org/job/maven-box/job/maven/ has a lot of broken branches. But also have a look at all the other projects. Decide for

Re: Merge MNG-2478 and MNG-6054 into 3.7.0

2020-04-25 Thread Robert Scholte
MNG-2478 seems okay I think MNG-6054 should wait for Maven 4, especially removing maven-release-plugin is too dangerous to me. I don't think the plugin checks if its version is set. If not it will likely pick up the latest, which is a milestone. Robert On 24-4-2020 14:58:20, Michael Osipov

Re: source directory layout for multirelease jars

2020-04-25 Thread Robert Scholte
I'm afraid this will be long story, but this might be the moment to share the details. https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html describes already several topics: - why MultiRelease Jars - how to build them? There are several patterns, each with its pro's and

[GitHub] [maven-doxia-site] elharo opened a new pull request #6: [DOXIA-540] delink old versions

2020-04-25 Thread GitBox
elharo opened a new pull request #6: URL: https://github.com/apache/maven-doxia-site/pull/6 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Romain Manni-Bucau
Le sam. 25 avr. 2020 à 18:38, Robert Oxspring a écrit : > > > On 25 Apr 2020, at 16:31, Romain Manni-Bucau > wrote: > > > > Le sam. 25 avr. 2020 à 17:12, Robert Oxspring > a > > écrit : > > > >> > >>> On 25 Apr 2020, at 15:37, Romain Manni-Bucau > >> wrote: > >>> > >>> Hi Robert, two

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Robert Oxspring
> On 25 Apr 2020, at 16:31, Romain Manni-Bucau wrote: > > Le sam. 25 avr. 2020 à 17:12, Robert Oxspring a > écrit : > >> >>> On 25 Apr 2020, at 15:37, Romain Manni-Bucau >> wrote: >>> >>> Hi Robert, two thoughts maybe >>> >>> 1. all that work (thinking also of assembly one) should

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Romain Manni-Bucau
Le sam. 25 avr. 2020 à 17:12, Robert Oxspring a écrit : > > > On 25 Apr 2020, at 15:37, Romain Manni-Bucau > wrote: > > > > Hi Robert, two thoughts maybe > > > > 1. all that work (thinking also of assembly one) should probably end up > by > > enriching > > >

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Robert Oxspring
> On 25 Apr 2020, at 15:37, Romain Manni-Bucau wrote: > > Hi Robert, two thoughts maybe > > 1. all that work (thinking also of assembly one) should probably end up by > enriching >

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Karl Heinz Marbaise
Hi, On 25.04.20 16:25, Robert Oxspring wrote: Hi “mvn clean install” is definitely normal for small projects like maven plugins because it’s a cheap way of guaranteeing your build is up to date. What does install guarantee which verify does not? For developers working on larger projects

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Romain Manni-Bucau
Hi Robert, two thoughts maybe 1. all that work (thinking also of assembly one) should probably end up by enriching https://github.com/apache/maven-shared-incremental/blob/master/src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java model and impl. I tend to think it does

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Robert Oxspring
Hi “mvn clean install” is definitely normal for small projects like maven plugins because it’s a cheap way of guaranteeing your build is up to date. For developers working on larger projects “mvn clean install” is typically avoided wherever possible as it forces everything to be rebuilt even

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Karl Heinz Marbaise
Hi, On 25.04.20 00:58, Robert Oxspring wrote: Hi all, When copying resources with filtering on, files are always overwritten even when the filters have not changed. I’d like to change this such that repeated filtering copies do not modify the destination file. I’ve prepared a change to

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Karl Heinz Marbaise
Hi, On 25.04.20 15:36, Slawomir Jaranowski wrote: Hi, Can you describe your case and what you want to achieve. By default all files created during maven running are write to target directory. And in most case target directory is cleaned before new build starting. Usual maven is running by:

Re: Maven Invoker Plugin - streamLogsOnFailures

2020-04-25 Thread Slawomir Jaranowski
Hi Did you found some time to look at my proposition? I'm waiting for your opinion. Maybe you need some more explanations. śr., 1 kwi 2020 o 17:58 Slawomir Jaranowski napisał(a): > A. > new parameters *streamLogsOnFailures* with boolean value - default false > - don't change current behavior,

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-25 Thread Slawomir Jaranowski
Hi, Can you describe your case and what you want to achieve. By default all files created during maven running are write to target directory. And in most case target directory is cleaned before new build starting. Usual maven is running by: mvn clean install. sob., 25 kwi 2020 o 00:59 Robert

[ANN] Apache Maven Wagon 3.4.0 released

2020-04-25 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Apache Maven Wagon, version 3.4.0. https://maven.apache.org/wagon/ Release Notes - Maven Wagon - Version 3.4.0 ** Bug * [WAGON-568] - Fail to deploy on Sonatype OSS since Maven 3.5.4 * [WAGON-573] -

[RESULT] [VOTE] Release Maven Wagon version 3.4.0

2020-04-25 Thread Michael Osipov
Hi, The vote has passed with the following result: +1: Michael Osipov, Olivier Lamy, Karl Heinz Marbaise, Robert Scholte, Hervé Boutemy PMC quorum: reached I will promote the artifacts to the central repo, the source release ZIP file and add this release the board report.