MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-01-15 Thread Falko Modler
Hi everyone, I'd like to raise awareness for the MavenProject concurrency problem that is causing MNG-6843 "Parallel build fails due to missing JAR artifacts in compilePath" [1] and probably others [2] [3] [4]. Almost a month ago, I created a ThreadLocal-based fix for this [5] (after another, ol

Re: releasing maven-artifact-plugin

2021-01-15 Thread Slawomir Jaranowski
Hi, I use org.apache.maven.repository.RepositorySystem#createArtifactWithClassifier - it is not Maybe the java version can also be upgraded to 1.8 New plugin and start with 1.7 is a special requirement for it? pt., 15 sty 2021 o 12:50 Elliotte Rusty Harold napisał(a): > I noticed this code i

Re: releasing maven-artifact-plugin

2021-01-15 Thread Robert Scholte
We've already discussed this. The name is intended to be generic and can be seen as a "brother" of the maven-dependency-plugin. Where the dependency plugin handles the (dependency) graph, the artifact plugin is about the (artifact) file. I expect more goals to be added. thanks, Robert On 15-1-20

Re: releasing maven-artifact-plugin

2021-01-15 Thread Elliotte Rusty Harold
Where possible I'd try to replace plexus utils such as StringUtils and FileUtils with better maintained JDK or Apache commons alternatives. On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote: > > I want to release Maven Artifact Plugin soon, version 0.1 > > I did a first documentation: > https:/

Re: releasing maven-artifact-plugin

2021-01-15 Thread Elliotte Rusty Harold
There are some good integration tests. Unit tests would help round this out. Most classes and method appear public by default. It's not obvious they need to be. I think almost all of them could be private or package private instead. They can always be made public later if a need is uncovered, but

Re: releasing maven-artifact-plugin

2021-01-15 Thread Elliotte Rusty Harold
The use of PrintWriter in BuildInfoWriter is error prone because it swallows exceptions. This should be replaced with an OutputStreamWriter. On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote: > > I want to release Maven Artifact Plugin soon, version 0.1 > > I did a first documentation: > https:

Re: releasing maven-artifact-plugin

2021-01-15 Thread Elliotte Rusty Harold
I noticed this code in ReferenceBuildInfo: Artifact buildinfo = artifactFactory.createArtifactWithClassifier( project.getGroupId(), project.getArtifactId(), project.getVersion(), "buildinfo", "" ); The problem is that ArtifactFactory is deprecated and has been fo

Re: releasing maven-artifact-plugin

2021-01-15 Thread Elliotte Rusty Harold
The name of this plugin, Maven Artifact Plugin, seems very generic. It really gives no indication of its purpose. Perhaps consider a rename at this early stage to maven-buildinfo-plugin or maven-reproduce-plugin. On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote: > > I want to release Maven Art

Re: releasing maven-artifact-plugin

2021-01-15 Thread Matthieu Brouillard
Hi Hervé, As far as I understood the docs, the _buildinfo_ goal has 2 purposes: 1. generate the .buildinfo file 2. optionally check it against some reference Shouldn't these two use cases be provided by two different goals? By having them in the same goal the "reference.repo" property "pollutes"

[GitHub] [maven-site-plugin] michael-o merged pull request #35: Fix script injection example in docs

2021-01-15 Thread GitBox
michael-o merged pull request #35: URL: https://github.com/apache/maven-site-plugin/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [maven-site-plugin] strkkk opened a new pull request #35: Fix script injection example in docs

2021-01-15 Thread GitBox
strkkk opened a new pull request #35: URL: https://github.com/apache/maven-site-plugin/pull/35 Example is not good since self-closing tag wont work, so it is changed to correct example. See [stackoverflow](https://stackoverflow.com/questions/4531772/can-the-script-tag-not-be-self-close

JDK 16 is now in Rampdown Phase Two

2021-01-15 Thread Rory O'Donnell
Hi Robert , *Per the JDK 16 schedule , we are in Rampdown Phase Two* *[1] . * *Please advise if you find any issues while testing the latest Early Access builds.* * Schedule for JDK 16 o *2021/01/14  Rampdown Phase Two* o 2021/02/04  Initial Release Candidate o 2021/02/18  Fin