Re: [maven-enforcer-plugin] Any plans on releasing 3.0.0-M4?

2021-01-24 Thread Benjamin Marwell
Thanks for the PR! We will review it soon. After that I will try to push for a release as requested. Am Mo., 25. Jan. 2021 um 00:43 Uhr schrieb Artem Krosheninnikov : > > Hello, just in case it is a blocker for a new milestone version, I've made > a corresponding PR to add exclusion/inclusion

Re: Loging api in JSR-330 component

2021-01-24 Thread Guillaume Nodet
+1 for giving the logging API a bit of love with Supplier and/or formatter-like api. Guillaume Nodet Le lun. 25 janv. 2021 à 07:41, Mark Struberg a écrit : > +1Technically from a pure ClassLoader point our very own makes more > sense.We can probably think about Lambda to resolve the String >

Re: Loging api in JSR-330 component

2021-01-24 Thread Mark Struberg
+1Technically from a pure ClassLoader point our very own makes more sense.We can probably think about Lambda to resolve the String lazily.Insofar the SLF4J api is outdated as well. And of course internally we might still route to slf4j. But we should not expose those classes to the plugins if

Re: Loging api in JSR-330 component

2021-01-24 Thread Mark Struberg
    @Inject     private Logger??? logger; That would imo depend on the package of the Logger in the import. There could be producers for both our internal maven logging api and SLF4J. LieGrue,strub On Friday, 22 January 2021, 19:19:47 CET, Slawomir Jaranowski wrote: It is not only

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

2021-01-24 Thread Mark Struberg
+1 LieGrue,strub On Sunday, 24 January 2021, 00:02:35 CET, Sylwester Lachiewicz wrote: Hi, We solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12347024=Text There are still a couple of issues left in JIRA:

Re: [maven-enforcer-plugin] Any plans on releasing 3.0.0-M4?

2021-01-24 Thread Artem Krosheninnikov
Hello, just in case it is a blocker for a new milestone version, I've made a corresponding PR to add exclusion/inclusion support [1], feel free to have a look. [1] https://github.com/apache/maven-enforcer/pull/86 ср, 20 янв. 2021 г. в 22:50, Benjamin Marwell : > Hi, > > in [1] MENFORCER-338,

Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-01-24 Thread Tibor Digana
Hi Falco, This is not the first time I have been talking about these principles in our team. Seven years ago and then in 2019. But sorry I cannot force the people to do it and they have to start by themself. We have to do it together. All I can do is to provide some training and elaborate a

[GitHub] [maven-site-plugin] slachiewicz commented on pull request #34: [DOXIA-616]

2021-01-24 Thread GitBox
slachiewicz commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766441620 I'll look at it tomorrow This is an automated message from the Apache Git Service. To respond to the

Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-01-24 Thread Falko Modler
Hi Tibor, thanks for this very elaborate answer and I always appreciate your feedback, but to me it kind of misses the point a bit...? may not necessarily have to do with concurrent access. But it does in this special case. Please see the issue and the linked explanations. The solution with

[GitHub] [maven-site-plugin] michael-o commented on pull request #34: [DOXIA-616]

2021-01-24 Thread GitBox
michael-o commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766434017 I won't be able to review before mid Feb due to circumstances here. This is an automated message from

[GitHub] [maven-site-plugin] bertysentry commented on pull request #34: [DOXIA-616]

2021-01-24 Thread GitBox
bertysentry commented on pull request #34: URL: https://github.com/apache/maven-site-plugin/pull/34#issuecomment-766418215 @michael-o @hboutemy @elharo Friendly reminder that this PR is still waiting, and its content is not going to change with regards to the failed builds, which are

Re: Build windows-jdk15

2021-01-24 Thread Robert Scholte
INFRA made some changes and so far Windows + JDK15 looks stable again. The new issue might be Linux + Java 16-ea On 6-1-2021 09:44:19, Benjamin Marwell wrote: If this happens again, Please add it to the ticket as requested by infra. Link below. Thanks - Ben

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

2021-01-24 Thread Benjamin Marwell
Depends. But good catch anyway. Offending line: && file.equals( violation.file ) The only field without null check in the constructor or using Objects.equals. Can there be a violation without a file though? Ie outside a file? If not, let's "fix" it in the next release. On Sun, 24 Jan

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

2021-01-24 Thread Elliotte Rusty Harold
There's at least one NullPointerException in the new Violation class's equals method, possibly others. I'm -1. package org.apache.maven.plugins.checkstyle; import org.junit.Assert; import org.junit.Test; public class ViolationTest { @Test public void testEquals() { Violation

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

2021-01-24 Thread Benjamin Marwell
[X] +1 (non binding) sha512 is correct for me Works in a sample project. Am So., 24. Jan. 2021 um 00:02 Uhr schrieb Sylwester Lachiewicz : > > Hi, > > We solved 5 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12347024=Text > > There are still a couple of

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

2021-01-24 Thread Romain Manni-Bucau
+1 (non binding) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book