[GitHub] maven-plugins pull request #122: Replace the deprecated RemappingClassAdapte...

2017-07-10 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-plugins/pull/122 Replace the deprecated RemappingClassAdapter with ClassRemapper Hi, RemappingClassAdapter has been deprecated in ASM 5.0, and in the version 6.0 it starts spitting RuntimeExceptions

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

2017-05-21 Thread ebourg
Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 Thank you. The add-source trick is a bit problematic for the Debian packaging because we don't build the source jars, but we can live with a Debian specific patch using the shade plugin instead

[GitHub] maven issue #109: Updated Mockito, slf4j and logback dependences to latest v...

2017-05-17 Thread ebourg
Github user ebourg commented on the issue: https://github.com/apache/maven/pull/109 #118 also upgrades SLF4J but goes a bit further by removing the patching mechanism. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

2017-05-17 Thread ebourg
Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 It's better now, the levels and the exceptions are properly colored, and SLF4J no longer complains about the duplicate StaticLoggerBinder. --- If your project is set up for it, you can reply

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

2017-05-17 Thread ebourg
Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 Understood, thank you. I've added a StaticLoggerBinder implementation but now SLF4J complains that there are two StaticLoggerBinder on the classpath (from maven-slf4j-provider and slf4j-simple). I'll

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

2017-05-16 Thread ebourg
Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 Is the StaticLoggerBinder implementation necessary? I built Maven without and it seemed to work, the resulting version was able to build a couple of random projects and the console output was colored

[GitHub] maven pull request #118: Upgrade SLF4J to 1.7.25 and expelled the groovy mon...

2017-05-16 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven/pull/118 Upgrade SLF4J to 1.7.25 and expelled the groovy monkey The changes to SLF4J required to support maven-slf4j-provider have been [released ](https://jira.qos.ch/browse/SLF4J-394) in the version 1.7.25

[GitHub] maven-scm pull request: Replace jakarta-regexp with java.util.rege...

2014-02-24 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-scm/pull/10 Replace jakarta-regexp with java.util.regex Hi, I'd like to suggest the removal of the dependency on the old jakarta-regexp API and replace it with the standard `java.util.regex` API

maven-scm pull request: Upgrade the dependency on JUnit (4.11) and Hamcrest...

2014-01-29 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-scm/pull/7 Upgrade the dependency on JUnit (4.11) and Hamcrest (1.3) Hi, The maven-scm-provider-accurev tests do not compile with the latest version of JUnit and Hamcrest. Here is a patch fixing

maven-shared pull request: Upgrade the dependency on maven-artifact for mav...

2014-01-20 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-shared/pull/4 Upgrade the dependency on maven-artifact for maven-shared-io Hi, A maven-shared-io test doesn't compile against maven-artifact 2.2.1 because the signature of a constructor changed

maven-shared pull request: Upgrade the dependency on Easymock to 3.2

2013-12-04 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-shared/pull/3 Upgrade the dependency on Easymock to 3.2 Hi, This is a follow up of the Easymock upgrade on the Maven components. You can merge this pull request into a Git repository by running

maven-shared pull request: Upgrade the dependency on Easymock to 3.2

2013-12-04 Thread ebourg
Github user ebourg closed the pull request at: https://github.com/apache/maven-shared/pull/3 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-plugin-testing pull request: Upgrade the dependency on Easymock to 3....

2013-11-22 Thread ebourg
Github user ebourg closed the pull request at: https://github.com/apache/maven-plugin-testing/pull/2 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-wagon pull request: Use EasyMock instead of SessionListenerMock and T...

2013-11-14 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-wagon/pull/9 Use EasyMock instead of SessionListenerMock and TransferListenerMock Here is another change I'd like to suggest, `SessionListenerMock` and `TransferListenerMock` can be replaced with dynamic

maven-wagon pull request: Use EasyMock instead of SessionListenerMock and T...

2013-11-14 Thread ebourg
Github user ebourg closed the pull request at: https://github.com/apache/maven-wagon/pull/9 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-wagon pull request: Code cleanup

2013-11-13 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-wagon/pull/8 Code cleanup Here is a patch performing minor code improvements (foreach loops, generics, unused imports, StringBuilders, etc) You can merge this pull request into a Git repository by running

maven-plugin-testing pull request: Upgrade the dependency on Easymock to 3....

2013-11-13 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-plugin-testing/pull/2 Upgrade the dependency on Easymock to 3.2 The `MockControl` class used by `MockManager` in the maven-test-tools artifact has been removed from EasyMock starting with version 3.0

maven-wagon pull request: Code cleanup

2013-11-13 Thread ebourg
Github user ebourg closed the pull request at: https://github.com/apache/maven-wagon/pull/8 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-wagon pull request: Upgrade the dependency on Easymock to 3.2

2013-11-12 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-wagon/pull/7 Upgrade the dependency on Easymock to 3.2 Hi, Wagon depends on a rather old version of EasyMock. The class `MockControl` used in several tests has been deprecated in EasyMock 2.0 (2005

maven-wagon pull request: Upgrade the dependency on Easymock to 3.2

2013-11-12 Thread ebourg
Github user ebourg closed the pull request at: https://github.com/apache/maven-wagon/pull/7 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-plugin-tools pull request: Update the groupId for beanshell

2013-10-25 Thread ebourg
GitHub user ebourg opened a pull request: https://github.com/apache/maven-plugin-tools/pull/3 Update the groupId for beanshell A minor update for beanshell You can merge this pull request into a Git repository by running: $ git pull https://github.com/ebourg/maven-plugin-tools

maven-plugin-tools pull request: Update the groupId for beanshell

2013-10-25 Thread ebourg
Github user ebourg closed the pull request at: https://github.com/apache/maven-plugin-tools/pull/3 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org