Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/151
other topics:
- MNG-5968 is closed
- MNG-5968 is not about default plugins versions, but about Maven core build
if you rework this PR to focus on MNG-5992, ie providing a more secure
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/151
I'm not a fan of default plugins updates in core:
- depending on default versions is a bad practice, we expect users to
explicitely choose their version through pluginManagement (and we display
Github user hboutemy commented on the issue:
https://github.com/apache/maven-indexer/pull/23
sorry, I did not notice you were working on it, I did some checkstyle fixes
that messed your work :(
---
-
To unsubscribe
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/136
merged as a branch in Maven git
https://github.com/apache/maven/tree/MNG-6302_module-progress
and reworked to avoid additional line "Module i/n" but have instead
integrated
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/109
great, thank you
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/118
ideas added to the MNG-6196 branch in
https://github.com/apache/maven/commit/c2a8787eb7450cb28d7f08698788c5e58a3f8a02
: no monkey patch any more
I kept dependency:unpack+build-helper:add-source
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/118
great, I'll merge your ideas with
https://github.com/apache/maven/commit/75b23eb01f913cf90d6ac4f9d2d5d7f6b9d69e1a
: removing the patching part will be a be a good benefit
issue tracked
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/118
AFAIK, you have colors on messages, but not on levels: the specific logger
is necessary for levels.
It's also necessary for colored error rendering.
Just look at MavenSimpleLogger and you'll
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
yes: now that ASF Jenkins shows me it works not only on my Linux box but
also on ASF Linux and on Windows, I just closed the Jira issue
---
If your project is set up for it, you can reply
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
FYI I'm running Kubuntu 16.10
not a big issue: thank your for the great job
please take time to close the PR
---
If your project is set up for it, you can reply to this email and have your
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
I just merged the patch
I had to change `==` tests to `=` since it did not work on Linux: the
result is `if [ "$arg" = "-f" -o "$arg" = "--file" ]; t
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
IMHO, the first thing is to check in the current fix, since ITs are
currently broken
then improving the IT to check more parts could be interesting: priority 2
---
If your project is set up
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
yes, that's exactly the part I was looking for. The shell script:
1. finds the basedir
2. uses it to load `jvm.config`
3. then injects the value as `maven.multiModuleProjectDirectory
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
maybe I'm missing something...
{{.mvn}} directory has to be found by shell script because of
{{jvm.config}} particularly
But once he directory is found by shell script, I suppose
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
IT moved to its own suite in
https://github.com/apache/maven-integration-testing/commit/3311f4e345fe7e6c343fae737631b727aba5b910
to avoid running this IT with Maven 3.3.x, as it will fail
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
IT added
https://github.com/apache/maven-integration-testing/commit/2e74409fc2593b4478c40f28c7fdabc60202c06b
no change on existing ITs, just added an additional run with different
execution state
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
I know core ITs are intimidating: it took me years to really dig into the
code!
This case seems a simple one (what I didn't really expect when thinking at
it initially), since it's only improving
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
let's help: I dug into core-its, to find what existing IT to extend, since
.mvn feature should have an IT already
=> found mng-5771-core-extensions IT, which already tests 3 conditions: I
th
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77742105
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java
---
@@ -0,0 +1,126 @@
+package
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77741146
--- Diff:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
---
@@ -34,10 +34,11 @@
import
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77579970
--- Diff:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
---
@@ -38,11 +38,16 @@
import
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77579682
--- Diff:
surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
---
@@ -46,10 +48,8 @@
import static
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77579430
--- Diff:
surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/Level.java
---
@@ -0,0 +1,83 @@
+package
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77447554
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java
---
@@ -0,0 +1,126 @@
+package
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77447349
--- Diff: maven-failsafe-plugin/pom.xml ---
@@ -127,6 +127,19 @@
true
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven/pull/81#discussion_r66704747
--- Diff:
maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
---
@@ -0,0 +1,165 @@
+package
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/81
I just committed the code, slightly modified since Maven general color
support was added in MNG-3507 (after extracting some code from this provider)
I tested with core ITs and fixed one little
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-78220459
thank you for your work: the bugs are fixed now, cobertura-maven-plugin and
m-site-p ITs pass
now back to the start of this PR :)
Christian: did you know
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77975130
another issue found regarding slf4j, this time with cobertura plugin,
during instrumentation http://jira.codehaus.org/browse/MNG-5783 created, with
the difference
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77440946
yes, it was just fixed in http://jira.codehaus.org/browse/MNG-5779
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-77110127
the current head is expected to be released soon: we'll need to investigate
before releasing, IMHO
comparing 3.2.5 to actual head, slf4j version did not change
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-76888558
Reporting is a key feature of Maven I strongly want to keep working (or fix
when we introduced problems while improving build consistency during Maven 3.x
refactoring
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68425530
The worst is that open implementation can change the status of objects by
any plugin: yes, the API wasn't meant to be defensive when it was created, we
could simply tell
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/32#issuecomment-68146338
I completely understand Christian motivation: we have a problem when we
need interaction between non-default lifecycle and default lifecycle
this causes multiple
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven/pull/28#discussion_r19627514
--- Diff: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
---
@@ -137,6 +139,7 @@ public CLIManager()
options.addOption
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven/pull/28#discussion_r19627615
--- Diff: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
---
@@ -924,7 +924,7 @@ else if ( profileAction.startsWith
36 matches
Mail list logo
