jvanzyl commented on pull request #1:
URL:
https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980635194
I'm not sure why the slight change was made, but the latest published
instructions put the JAR in there by default. Just a warning that it's asking
for potential
jvanzyl commented on pull request #1:
URL:
https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633136
I think that's a poor default behavior, and the `type=bin` should be the
default. That's not how the current released wrapper work, no one will read the
docs and the
jvanzyl commented on pull request #1:
URL:
https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980613922
I run the following in the clone repository itself:
```
mvn clean install
mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper
./mvnw
jvanzyl commented on pull request #1:
URL:
https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974671779
@rfscholte are you fine with a first step of dynamically importing the
scripts and implementing the more sophisticated
https://issues.apache.org/jira/browse/MWRAPPER-16
jvanzyl commented on pull request #1:
URL:
https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974671779
@rfscholte are you fine with a first step of dynamically importing the
scripts and implementing the more sophisticated
https://issues.apache.org/jira/browse/MWRAPPER-16
jvanzyl commented on pull request #1:
URL:
https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970336499
Historically the Maven Wrapper has been separate, and I believe works well
that way. Its concern to bring Maven into existence for build, and I would
argue that should
jvanzyl commented on pull request #1:
URL:
https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970322319
> Another idea ... why not simply call `mvn*` scripts from Maven
distribution ... of course after needed job for wrapper like downloading
>
> In this case code
