[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...

2016-05-25 Thread eddiewebb
Github user eddiewebb commented on the pull request: https://github.com/apache/maven-scm/pull/44#issuecomment-221606935 @olamy @rodrigc @msperisen - I also submitted https://github.com/apache/maven-scm/pull/45 around the same time for similar issue with native git client. --- If

[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-scm/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...

2016-05-21 Thread rodrigc
Github user rodrigc commented on the pull request: https://github.com/apache/maven-scm/pull/44#issuecomment-220794627 @olamy @khmarbaise If you could look at this issue and also do a new release of maven-scm, that would be greatly appreciated. That would also help with the issue

[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...

2016-05-18 Thread msperisen
Github user msperisen commented on the pull request: https://github.com/apache/maven-scm/pull/44#issuecomment-219951622 great, this solves a big issue we are having! @olamy, can you comment on the implementation and if/when this could be merged and make it into a release? --- If

[GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...

2016-02-05 Thread eddiewebb
GitHub user eddiewebb opened a pull request: https://github.com/apache/maven-scm/pull/44 #resolves SCM-817 by encoding password before replace This resolves https://issues.apache.org/jira/browse/SCM-817 by encoding the password before trying to match against the pre-encoded URL.