[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-18 Thread khospodarysko
Github user khospodarysko commented on the issue: https://github.com/apache/maven-surefire/pull/121 @Tibor17 No, I haven't. This is my first such patch. I'm happy it added more quality to the product! --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-18 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 @khospodarysko CI build was successful. This should be normally closed automatically and sometimes it takes a day but you can close it as well. Thank you for contributing. Have you

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-18 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-18 Thread khospodarysko
Github user khospodarysko commented on the issue: https://github.com/apache/maven-surefire/pull/121 Followed the analogy and added org.apache.maven.surefire.its.jiras.Surefire1278GroupNameEndingIT to src/test/java folder. Please let me know if something else is wrong and I'll try

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-18 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 @khospodarysko Do you have it in *.bak file or in bytecode in /target/classes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-18 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 @khospodarysko Something wrong happened. The IT class is missing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-17 Thread khospodarysko
Github user khospodarysko commented on the issue: https://github.com/apache/maven-surefire/pull/121 Squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-16 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/121 @khospodarysko Can you squash two commits to one single commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #121: Fix for issue SUREFIRE-1278

2016-09-16 Thread khospodarysko
Github user khospodarysko commented on the issue: https://github.com/apache/maven-surefire/pull/121 Btw did not receive a failures after: mvn -Prun-its clean install or mvn clean install --- If your project is set up for it, you can reply to this email and have your