[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-13 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 @Tibor17 Wouldn't it be better to rebase junit5 branch onto master? I don't have push access to maven-surefire, so you would have to do the trick. --- If your project is set up for it, you

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-12 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter Finally please merge master to junit5 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-11 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 Okay, this is reintegrated. I will fix it in another PR. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-10 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter The only problem is with workspace for the `Junit4VersionsIT` which is `/target/Junit4VersionsIT_testJunit` same for all parameters. Therefore we should not take the only

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-10 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-10 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 We need to rebase the junit5 branch after this has been merged in order to pick up this changes. --- If your project is set up for it, you can reply to this email and have your reply appear