Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
Yeah, I have released 2.20.1 and I had to postpone this issue for 2.21.1.
OOM was fixed in 2.20.1 and users could not wait longer. This included
Java9 support.
Java
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - any updates?
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands,
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 I see what you're going for, that makes sense.
I've update my PR to just include IT contents now, with an improved IT that
emulates a scenario where working copy changes
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
My tests passed on this code. I have to continue to develop and refactor
more.
List testDepends = project.getTestArtifacts();
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I will try by myself. I will let you know with new branch and we can
discuss it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I don't think that logic would work for my scenario.
For example:
1. Create multi-module project with a test runner JAR (a la
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
It would be easier for you not to rever 569 in this PR but create a new PR
from master. I pushed a new fix to master today. The master will be idle for
you.
---
If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I found the root cause.
The dependency to scan is examined with outputDirectory, but IT 569 has
shources to share in `src/test/java` so the artifact would match but
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - IT569 does not **fail** when introducing my changes. But since
the test was written as a single lifecycle, it inadvertently uses the code I've
introduced in this PR ([see
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I built the project. It was ok but then I realized you modified IT 569
which I do not like because this was a feature and I want to guarantee that old
tests pass without
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@JoelNGeorge
@owenfarrell
Pls let me run the build and next steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user JoelNGeorge commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I have the exact same issue. This fix is very much appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I have not had yet. I am reviewing other in parallel.
I will have a look in few days.
---
If your project is set up for it, you can reply to this email and have your
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - Have you had a chance to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
And I got busy with other work as well. I think I found a solution that
doesn't completely violate the pattern used by integration tests.
Long story short, the IT for
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I have been busy with other ticket. Where did we finish. Do you need a help?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Copying the `it-parent` POM over to the output directory as part of
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I don't follow. When I run an install from any level, the
`org.apache.maven.surefire:it-parent:1.0:pom` artifact
(surefire-integration-tests/src/test/resources/pom.xml) does not get
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
No, no.
No worries.
You should build entire project `mvn install` and not the individual IT.
The ITs cannot run separately, you can trigger it from building entire
project from
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
One workaround for this would be to install the missing `it-parent` POM as
part of my first lifecycle (i.e. mid-test). But this seems kind of hacky.
```
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Looking at it a bit deeper, looks like the root cause is that the
`it-parent` POM is not installed in the IT repo. The issue isn't the dependency
itself.
---
If your project is set up
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I've put together an integration test that can validate the execution of
[SUREFIRE-1383](https://issues.apache.org/jira/browse/SUREFIRE-1383). And all
is good on that front.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Would you add integration test?
See the module `surefire-integration-tests` and
`src/test/java/org/apache/maven/surefire/its/jiras`.
It's easy. Pickup some existing test, e.g.
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Pls squash both commits to one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
26 matches
Mail list logo
