[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143544670 @lamyaa I applied the local change and executed XmlReporterRunTimeIT. The balancer is really applied and Test1 was really executed within 600 millis.

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143595744 @Tibor17 I'm very sorry for the delay. Please go ahead and finish this one if you have time. I'm not quite sure how XmlReporterRunTimeIT works either. I

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143595094 @lamyaa Can I finish it unless you you are already in progress? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143606448 @lamyaa Pls close this pull-request. I have pushed the fix including your IT. Thx for the IT, it was very nice work. --- If your project is set up for

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa closed the pull request at: https://github.com/apache/maven-surefire/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143607529 Thanks for taking care of this @Tibor17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-141173488 @lamyaa I will have a look into this test. On Thu, Sep 17, 2015 at 7:19 PM, lamyaa wrote: > @Tibor17

Re: [GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==> > . > NAML > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer=instant_html%21nabble%3Aemail.naml=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-141156540 @Tibor17 As I was preparing a new pull request with the simple change: ``createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix,

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140308340 Yes a new pull request would be great. I have made a lot of rework in surefire. Most probably this branch is not able to merge. On 9/14/15, lamyaa

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140148135 @Tibor17 I tried just changing the last parameter like you suggested: ``createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix,

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140152959 @Tibor17 ``createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix, testSetReportEntry.elapsedTimeAsString() )`` does fix the issue.

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140153614 @Tibor17 It seems that we have a check for elapsed time being null in TestSetRunListerner.java so we never instantiate WrappedReportEntry with a null elapsed

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-139858232 @lamyaa I think I found a solution which works on my side with non-parallel tests. Feel free to tell me what you think about my hypothesis. Can you

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-139917934 @Tibor17 Please give me a couple of days to look again at this. It's not very fresh in my mind anymore :) --- If your project is set up for it, you can reply to

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-139915061 IMHO all we need to do is to change the last parameter: `createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix,

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-138134180 @lamyaa Sorry for waiting so long time. I have finished issue 580. I will have a look on this since now. --- If your project is set up for it, you can

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

GitHub user lamyaa opened a pull request: https://github.com/apache/maven-surefire/pull/98 [Surefire-1144] Time for testsuite on commandline does not suit with the time value given in the report file https://issues.apache.org/jira/browse/SUREFIRE-1144 This pull request