[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-143954421 We can try with junit4 of course. On Tue, Sep 29, 2015 at 12:59 AM, lamyaa wrote: > @Tibor17

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-143896973 @Tibor17 I just tried junit47 for the first time. Indeed, it seems to already run test at the end like I was attempting to do in this PR with junit4. Do you

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-142747818 Hi @lamyaa What should we do with this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-142768756 @Tibor17 I haven't had a chance to look at junit47 provider yet. I'm hoping to get to it (as well as surefire-1144) this weekend. --- If your project is set up

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-136962698 Pls import code style to your IDE. https://maven.apache.org/developers/conventions/code.html#IntelliJ_IDEA_4.5 For instance in IntelliJ IDEA you import

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-136964837 Why you have `rerunAtEnd( reporterFactory, result.getFailures() ); ` after `runNotifier.fireTestRunFinished( result );`? I am not sure if test report

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137210814 > I am not sure if test report would be updated after test run has finished. What was intended? From my understanding, rerunAtEnd again calls

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137231366 Oh, I see. I never looked into junit47 provide in detail. I'll look into it and see how rerunFailingTestsAtEndCount can fit there. --- If your project is set up

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137228645 The junit47 provider runs all reruns in the after phase. If you use this provider, would it help the users? We should mention few differences between providers

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137207940 > Did you run the build (mvn install)? Yes, I did run mvn install and made sure that the checkstyle plugin passes. Are you maybe just seeing some weird line

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

GitHub user lamyaa opened a pull request: https://github.com/apache/maven-surefire/pull/102 Option to rerun failures at the end of test execution This PR introduces an option to rerun failing tests at the end of a test suite execution. The current option