Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
yes: now that ASF Jenkins shows me it works not only on my Linux box but
also on ASF Linux and on Windows, I just closed the Jira issue
---
If your project is set up for it, you can reply to this
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy Are you waiting for the Jenkins build to close the JIRA issue?
@rpatrick00 Thank you for the contribution.
---
If your project is set up for it, you can reply to this email and have your
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
FYI I'm running Kubuntu 16.10
not a big issue: thank your for the great job
please take time to close the PR
---
If your project is set up for it, you can reply to this email and have your
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy, sorry but both "==" and "=" seem to work fine on Oracle Linux
and MacOS (where I tested the sh script). Not sure which version of Linux
caused this but thanks for fixing it...
---
If
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
I just merged the patch
I had to change `==` tests to `=` since it did not work on Linux: the
result is `if [ "$arg" = "-f" -o "$arg" = "--file" ]; then`
And it required a little update to the
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
IMHO, the first thing is to check in the current fix, since ITs are
currently broken
then improving the IT to check more parts could be interesting: priority 2
---
If your project is set up for
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy I would at least check for `jvm.config` because this is expanded
in the script itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
yes, that's exactly the part I was looking for. The shell script:
1. finds the basedir
2. uses it to load `jvm.config`
3. then injects the value as `maven.multiModuleProjectDirectory`
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
If you look at the shell script, it used to compute the "basedir" variable
starting at the current working directory and then search upwards for the .mvn
directory. Then, it set the
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@rpatrick00 Can you shed some light here? What do you to properly picked
up? `extensions.xml`, `maven.config`, and `jvm.config`, right?
---
If your project is set up for it, you can reply to this
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
maybe I'm missing something...
{{.mvn}} directory has to be found by shell script because of
{{jvm.config}} particularly
But once he directory is found by shell script, I suppose it is
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy I am bit confused by the IT. The issue was about having `.mvn`
properly located to expand `maven.config`. I would expect some system property
to be added and retrieved. Am I wrong?
---
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
IT moved to its own suite in
https://github.com/apache/maven-integration-testing/commit/3311f4e345fe7e6c343fae737631b727aba5b910
to avoid running this IT with Maven 3.3.x, as it will fail
---
If
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
IT added
https://github.com/apache/maven-integration-testing/commit/2e74409fc2593b4478c40f28c7fdabc60202c06b
no change on existing ITs, just added an additional run with different
execution
Github user jvanzyl commented on the issue:
https://github.com/apache/maven/pull/94
Please do not change an existing test. The conditions under which this IT
passes should be left as-is and should continue running as it is in exactly the
form it runs now. Making purely additional
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
I took a quick look at the MNG-5771 IT and it's not obvious to me exactly
what I need to do so if you can add this in a few minutes, that is probably the
best thing to do. If not, I will try to
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
I know core ITs are intimidating: it took me years to really dig into the
code!
This case seems a simple one (what I didn't really expect when thinking at
it initially), since it's only improving
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy Thanks for helping out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hboutemy commented on the issue:
https://github.com/apache/maven/pull/94
let's help: I dug into core-its, to find what existing IT to extend, since
.mvn feature should have an IT already
=> found mng-5771-core-extensions IT, which already tests 3 conditions: I
think
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
@michael-o, while I have no problem contributing, I have no familiarity
with the maven-integration-test project so it will likely take me some time to
reverse engineer it enough to figure out how
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
I would rather see @rpatrick00 providing the IT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
@michael-o
I will merge it no problem. The only problem on IT is my spare time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
I think this really deserves an IT too. The shell script is fine. Can't
just on the command script, I am virtually illiterate here. I trust @rpatrick00
here. Willing to blindly to merge when the IT
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
@michael-o
Any objections to merget this or do we need to test it with specific use
case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
OK, addressed both comments from michael-o
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
@rpatrick00
LGTM
I have tested the change on Win7 and Fedora23.
I will merge your PR with master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
Pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
Don't create a new PR. Just amend the last commit `git commit --amend` and
push it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
OK, I found and resolved the problem with the --file arg but am not seeing
the other problem you describe (see output below). Maybe my fix for the --file
arg resolved that one too?
Here
Github user Tibor17 commented on the issue:
https://github.com/apache/maven/pull/94
@rpatrick00
It looks like "--file" is not recognize but "-file" is recognized.
The second issue where I have `/a/b` folders and `b` contains single
`pom.xml` and `.mvn` - no multimodule.
30 matches
Mail list logo
