Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user krosenvold commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113734189
Unfortunately I just merged the gigantic migrate everything to jdk7 branch,
which made this pull request stale. Can you re-align it, and I will merge it ?
---
If your
Github user sugartxy commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113748452
@krosenvold sorry for the mistake I've made. Does it work now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113755269
@sugartxy looks like @krosenvold is doing some JDK7 work so I'll let him
merge this.
---
If your project is set up for it, you can reply to this email and have your
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113717735
try-with-resources is cool.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sugartxy commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113768295
Oops! I misunderstood. Thank u! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user krosenvold commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113769042
There were some minor adjustments I did to your stuff, but nothing
significant :) Thanks a lot !
---
If your project is set up for it, you can reply to this email and
Github user sugartxy commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113709155
@jvanzyl Please let me know if you want something else to be done on this
pull request before you could merge it.
---
If your project is set up for it, you can reply
GitHub user sugartxy opened a pull request:
https://github.com/apache/maven/pull/53
#MNG-5844: Close IO Streams in finally block
Place the close method in the finally clause, so we can ensure it always
runs regardless of how the method exits.
You can merge this pull request
Github user sugartxy commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113508412
@ifedorenko @jvanzyl thx. I will rewrite it using try-with-resources ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ifedorenko commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113485035
Maven is targeting java 7 already, try-with-resource is more appropriate
way to guarantee IO streams are closed.
---
If your project is set up for it, you can reply
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/53#issuecomment-113505944
+1 please use try-with-resources
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
12 matches
Mail list logo
