Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-165627334
Can you please 'rebase' the commit onto 'origin/master' so that I can merge
it without conflicts?
---
If your project is set up for it, you can reply to this
Github user birkedal commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-138463968
It works just fine after the switch to backticks :+1:
I have no opinion on whether that other idiom is better or not.
One more little detail; if JAVA_HOME is
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-138297741
@birkedal, does this change look okay after the switch to backticks? Or, if
you're a Solaris user, does that other idiom seem better?
---
If your project is set up for
Github user birkedal commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-109946813
Looks like there are still problems on Solaris after applying the patch. It
seams like it's the `$()` that is problematic. See this comment on
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/50#issuecomment-110022166
I've pushed a further change to switch $(..) to backticks. However, perhaps
[this idiom](https://bugs.freedesktop.org/show_bug.cgi?id=5278) would be a
better way to
GitHub user josephw opened a pull request:
https://github.com/apache/maven/pull/50
MNG-5837: Use a subshell, rather than the 'local' keyword, for POSIX
compliance
'local' is not POSIX, but supported by most shells. However, it's not
supported by Solaris's /bin/sh, so use a
