[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread josephw
Github user josephw closed the pull request at: https://github.com/apache/maven/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-144029731 Fixed with 5cbc294e72c79955fb93c6434e9ac8ae7d9206cc. Please close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143988492 Already merged locally, running ITs... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143988014 Rebased onto 2a9a07b0a and re-pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143978524 @josephw Can you kind rebase on current master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-29 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143977320 Indeed, just tried for today and Thai calender gives me `2558-09-29`. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-28 Thread josephw
Github user josephw commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143918594 I've verified the behaviour. To reproduce: MAVEN_OPTS="-Duser.country=th -Duser.language=th" mvn deploy It doesn't fail, but the snapshot dates are inc

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-28 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143833287 Can you ping me by Thursday, I will review and merge?! Did you really observe it to fail with Thai locale? --- If your project is set up for it, you can reply to this e

[GitHub] maven pull request: MNG-5877: Ensure that snapshot versions use th...

2015-09-12 Thread josephw
GitHub user josephw opened a pull request: https://github.com/apache/maven/pull/65 MNG-5877: Ensure that snapshot versions use the Gregorian calendar. Snapshot versioning should use the Gregorian calendar for consistency across systems. Apply the fix reported by Anders Forsell to