Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-24 Thread Falko Modler
Hi Tibor, I've just updated https://issues.apache.org/jira/browse/MGPG-79. Hope this helps. Best regards, Falko Am 24.04.2020 um 13:11 schrieb Tibor Digana: Hi Falko, Can you attach the Thread dump while the GPG plugin hangs? This would simplify our work. Thx T On Wed, Apr 15, 2020 at 10:4

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-24 Thread Tibor Digana
Hi Falko, Can you attach the Thread dump while the GPG plugin hangs? This would simplify our work. Thx T On Wed, Apr 15, 2020 at 10:45 PM Falko Modler wrote: > > Hi, > > I just tried to to sign the output of > https://github.com/vackosar/gitflow-incremental-builder and I do not see > this error.

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-16 Thread Robert Scholte
For MGPG-59[1] the version had to be parsed because of a feature that only works for gpg2. Robert [1] https://issues.apache.org/jira/browse/MGPG-59 On 15-4-2020 23:12:47, Tibor Digana wrote: Why this plugin has been working for many years and with the same gpg installation? There has to be a

Re: [CANCELLED] [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-16 Thread Tibor Digana
I will open a new PR for issue 78. Currently the issue is the $ end tag in pattern https://github.com/apache/maven-gpg-plugin/blob/master/src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java#L50 however the number of versions should be limited to e.g. 3 which is enough. On Thu, Apr 16, 2020

[CANCELLED] [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Hervé BOUTEMY
this vote is cancelled because 2 issues found on Windows, with native gpg4win install or Git bash pgp port corresponding Jira issues created: https://issues.apache.org/jira/browse/MGPG-78 https://issues.apache.org/jira/browse/MGPG-79 please help fixing and testing Regards, Hervé Le dimanche 12

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Hervé BOUTEMY
yes, I hoped that it was an issue existing before, but your answer is clear: no, this is a new issue, with code newly introduced Given this issue on Windows and the issue on Linux, I'll cancel the release and create 2 Jira issues to track the 2 issues found we will require to fix and test on mu

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Elliotte Rusty Harold
Ther GPG plugin is using these two deprecated classes: import org.apache.maven.artifact.factory.ArtifactFactory; import org.apache.maven.artifact.metadata.ArtifactMetadata; However I can find no documentation about why these are deprecated are what is supposed to be used instead. Does anyone know

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Tibor Digana
Why this plugin has been working for many years and with the same gpg installation? There has to be a change in the comparator of versions according to the stacktrace. What other explanation? I did not change anything on my PC. Still the same set of tools. On Wed, Apr 15, 2020 at 11:07 PM Robert S

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Robert Scholte
gpg --version gpg (GnuPG) 2.2.15 libgcrypt 1.8.4 Copyright (C) 2019 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Falko Modler
Hi, I just tried to to sign the output of https://github.com/vackosar/gitflow-incremental-builder and I do not see this error. *But* the plugin simply hangs and does not continue if I use 3.0.0 after starting Kleopatra (https://docs.kde.org/stable5/en/pim/kleopatra/). When I first use 1.6 of th

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Tibor Digana
I am still using the same official version for the Windows since 2013. Many releases were done so far with this native installation in Maven. T On Wed, Apr 15, 2020 at 10:16 PM Hervé BOUTEMY wrote: > > questions to Windows users: > - what GPG distribution do you use, that does not make the plugin

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Hervé BOUTEMY
questions to Windows users: - what GPG distribution do you use, that does not make the plugin fail? - is this issue worth dropping the release? Regards, Hervé Le mercredi 15 avril 2020, 21:25:11 CEST Tibor Digana a écrit : > Sorry my -1 due to all integration tests have failed with the following

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Tibor Digana
Sorry my -1 due to all integration tests have failed with the following errors: Caused by: java.lang.IllegalArgumentException: Can't parse version of gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3) at org.apache.maven.plugins.gpg.GpgVersion.compareTo(GpgVersion.java:60) at org.apache.maven.plugins.gpg.

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Sylwester Lachiewicz
+1 Sylwek śr., 15 kwi 2020 o 18:54 Hervé BOUTEMY napisał(a): > here is my +1 > > regards, > > Hervé > > Le dimanche 12 avril 2020, 14:50:08 CEST Hervé BOUTEMY a écrit : > > Hi, > > > > We solved 13 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317521&ve > > rsi

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Hervé BOUTEMY
here is my +1 regards, Hervé Le dimanche 12 avril 2020, 14:50:08 CEST Hervé BOUTEMY a écrit : > Hi, > > We solved 13 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317521&ve > rsion=12330781&styleName=Text > > Staging repo: > https://repository.apache.org/content/

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Karl Heinz Marbaise
Hi, +1 from me. Kind regards Karl Heinz Marbaise On 12.04.20 14:50, Hervé BOUTEMY wrote: Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317521&version=12330781&styleName=Text Staging repo: https://repository.apache.org/content/repositories/maven-15

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-12 Thread Robert Scholte
There's no JIRA for it yet, I mentioned it last Thursday.  There are a couple of plugins that need to be verified and likely changed. It is kind of hard to manage these kind of things, especially when things are still work in progress. On 12-4-2020 19:14:19, Hervé BOUTEMY wrote: ok, IIUC, that m

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-12 Thread Hervé BOUTEMY
ok, IIUC, that means that this plugin will require a new release for Maven 3.7.0 is there a Jira issue already created for that? Regards, Hervé Le dimanche 12 avril 2020, 18:44:18 CEST Robert Scholte a écrit : > One side note: > To make this plugin work with the build/consumer pom it must be r

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-12 Thread Robert Scholte
One side note: To make this plugin work with the build/consumer pom it must be replaced with an InputStream based implementation. Now it is calling gpg via commandline with a reference to the files to sign. Robert On 12-4-2020 14:50:14, Hervé BOUTEMY wrote: Hi, We solved 13 issues: https://is

[VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-12 Thread Hervé BOUTEMY
Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317521&version=12330781&styleName=Text Staging repo: https://repository.apache.org/content/repositories/maven-1563/ https://repository.apache.org/content/repositories/maven-1563/org/apache/maven/plugins/