Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-07 Thread Graham Leggett
On 07 Jul 2019, at 20:51, Michael Osipov wrote: > I, too, now see this on the ASF Jenkins instance. > > Can you file an issue and add your finding please? I don't want your effort > to be lost in the archives. Someone needs to start digging to find the > mismatch. So the IT itself is fine, but

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-07 Thread Michael Osipov
Am 2019-07-07 um 12:13 schrieb Graham Leggett: On 06 Jul 2019, at 15:02, Graham Leggett wrote: I am at a loss as to why - after both tests above, pass and fail, there is no file anywhere called target/it/effective-site/effective-site.xml. The test itself seems straightforward. Create a file

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-07 Thread Graham Leggett
On 06 Jul 2019, at 15:02, Graham Leggett wrote: > I am at a loss as to why - after both tests above, pass and fail, there is no > file anywhere called target/it/effective-site/effective-site.xml. > > The test itself seems straightforward. Create a file called > effective-site.xml... > > [minf

[CANCELED] [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-07 Thread Michael Osipov
Vote has been canceled due to unresolved conflicts regarding Java 8. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-06 Thread Graham Leggett
On 04 Jul 2019, at 22:04, Michael Osipov wrote: >> One test failed, however this test also fails in maven-site-plugin v3.7.1, >> so this is not a regression: >> [INFO] Building: effective-site/pom.xml >> [INFO] run post-build script verify.groovy >> [INFO] effective-site/pom.xml ..

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-05 Thread Eric Lilja
+1 (non-binding) - Eric Lilja On Thu, Jul 4, 2019 at 10:04 PM Michael Osipov wrote: > Am 2019-07-03 um 23:54 schrieb Graham Leggett: > > On 01 Jul 2019, at 23:10, Michael Osipov wrote: > > > >> We solved 11 issues: > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=1231792

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Michael Osipov
Am 2019-07-03 um 23:54 schrieb Graham Leggett: On 01 Jul 2019, at 23:10, Michael Osipov wrote: We solved 11 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Michael Osipov
Am 2019-07-04 um 13:12 schrieb Tibor Digana: Did you read the Jira and the commit in Git? It was written in the way to push Java 8 without any strong reason, sorry for that but it's truth. I would like to see v9.2 first (after v6) in 3.8.1 and then wait for Maven 3.7.0 which will go most probably

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Michael Osipov
Am 2019-07-04 um 07:52 schrieb Tibor Digana: Additionally, if I want to make such a big change like using higher Java version, I have to upgrade the version of the plugin to 3.9.0 at least. I was pointing to Java 1.8 in the previous vote. This was done actually in 3.8.0, a minor release. I have

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Michael Osipov
That's not true. I answered you with the PR in Message-ID: <445f420e-6522-6d3c-53c4-27db0415a...@apache.org> Am 2019-07-04 um 07:39 schrieb Tibor Digana: -1: still no answered reasoning about Jetty 9 and Java 8. On Thu, Jul 4, 2019 at 8:32 AM Michael Osipov wrote: Am 2019-07-01 um 23:10 schr

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Bertrand Martin
+1 On 2019/07/01 21:10:52, Michael Osipov wrote: > Hi,> > > We solved 11 issues:> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145> > > There are still a couple of issues left in JIRA:> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSITE%

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Tibor Digana
Hello Graham, I agree with Herve who said in MSITE-837 that the goal "site:run" is temporarily used by developers when he wants to see the web content in browser. This goal should not be used in permanent deployment and of course not in public or production where the security has to be the importa

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Graham Leggett
On 04 Jul 2019, at 13:12, Tibor Digana wrote: > Did you read the Jira and the commit in Git? > It was written in the way to push Java 8 without any strong reason, sorry > for that but it's truth. I’m not following. Jetty is a compile time dependency of the maven-site-plugin, I believe it’s use

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Tibor Digana
Did you read the Jira and the commit in Git? It was written in the way to push Java 8 without any strong reason, sorry for that but it's truth. I would like to see v9.2 first (after v6) in 3.8.1 and then wait for Maven 3.7.0 which will go most probably with J8. We can release Site 3.9.0 and use it

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Graham Leggett
On 04 Jul 2019, at 09:03, Tibor Digana wrote: > The build passed successfully after I have used Jetty 9.2.9.v20150224. (no > need to change our code in the plugin) > It was the last J7 but v9.x Jetty. The reasoning in https://github.com/apache/maven-site-plugin/pull/3

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Olivier Lamy
+1 On Tue, 2 Jul 2019 at 9:10 am, Michael Osipov wrote: > Hi, > > We solved 11 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Tibor Digana
The build passed successfully after I have used Jetty 9.2.9.v20150224. (no need to change our code in the plugin) It was the last J7 but v9.x Jetty. On Mon, Jul 1, 2019 at 11:11 PM Michael Osipov wrote: > Hi, > > We solved 11 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?pro

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Tibor Digana
Additionally, if I want to make such a big change like using higher Java version, I have to upgrade the version of the plugin to 3.9.0 at least. I was pointing to Java 1.8 in the previous vote. And there's interesting unit test which fails. It needs to be investigated together with Graham in a sepa

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-04 Thread Tibor Digana
-1: still no answered reasoning about Jetty 9 and Java 8. On Thu, Jul 4, 2019 at 8:32 AM Michael Osipov wrote: > Am 2019-07-01 um 23:10 schrieb Michael Osipov: > > Hi, > > > > We solved 11 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145 >

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-03 Thread Michael Osipov
Am 2019-07-01 um 23:10 schrieb Michael Osipov: Hi, We solved 11 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSITE%20AND%20resolut

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-03 Thread Graham Leggett
On 01 Jul 2019, at 23:10, Michael Osipov wrote: > We solved 11 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSITE%20AND%20reso

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-03 Thread Michael Osipov
Am 2019-07-02 um 00:20 schrieb Tibor Digana: I could not find any (Jetty to MavenSite related) reasoning about versions of external frameworks in MSITE-828 and MSITE-829. Why you have used Jetty 9.4.12 compiled with J8 and not the Jetty 8.2.0 compiled with J7? What is the benefit to use v9.x and

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-01 Thread Tibor Digana
I could not find any (Jetty to MavenSite related) reasoning about versions of external frameworks in MSITE-828 and MSITE-829. Why you have used Jetty 9.4.12 compiled with J8 and not the Jetty 8.2.0 compiled with J7? What is the benefit to use v9.x and why not to use the v8.2.0? Would the Maven Sit

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-01 Thread Tibor Digana
no, sorry, very similar names: servlet and server. On Mon, Jul 1, 2019 at 11:58 PM Tibor Digana wrote: > Now the Jetty Server is there twice: > > > org.eclipse.jetty > jetty-servlet > ${jettyVersion} > > > On Mon, Jul 1, 2019 at 11:11 PM Michael Osipov > wrote: > >> Hi, >> >> We solved 11 iss

Re: [VOTE] Release Maven Site Plugin version 3.8.1

2019-07-01 Thread Tibor Digana
Now the Jetty Server is there twice: org.eclipse.jetty jetty-servlet ${jettyVersion} On Mon, Jul 1, 2019 at 11:11 PM Michael Osipov wrote: > Hi, > > We solved 11 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145 > > There are still a couple

[VOTE] Release Maven Site Plugin version 3.8.1

2019-07-01 Thread Michael Osipov
Hi, We solved 11 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923&version=12343145 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSITE%20AND%20resolution%20%3D%20Unresolved Staging repo: https://repos