[ http://jira.codehaus.org/browse/MASSEMBLY-25?page=comments#action_54746 ]
Brett Porter commented on MASSEMBLY-25:
---
sounds good. I definitely like (1).
Some changes I wkill likely do:
- if includeSiteDirectory were included in 2.0, we need to retain
[ http://jira.codehaus.org/browse/MASSEMBLY-25?page=comments#action_54758 ]
Jochen Wiedmann commented on MASSEMBLY-25:
--
Comments on Bretts reply:
- Retaining includeSiteDirectory: The proposed patch does retain this property.
I have no idea, how
[ http://jira.codehaus.org/browse/MASSEMBLY-25?page=comments#action_54819 ]
Brett Porter commented on MASSEMBLY-25:
---
I was just taking notes for myself, I hadn't reviewed in detail. I can probably
work with what you gave to solve this. Thanks!
[ http://jira.codehaus.org/browse/MASSEMBLY-25?page=comments#action_54825 ]
Brett Porter commented on MASSEMBLY-25:
---
comment on the patch: please follow existing code style. I have to reformat,
which is easy, but renaming all the variables is a bit
[ http://jira.codehaus.org/browse/MASSEMBLY-25?page=comments#action_54727 ]
Dan Tran commented on MASSEMBLY-25:
---
Jochen,
could you stay in maven-assembly-plugin and do a diff again? Your patch has
your full path.
Support for multiple assembly