Re: [maven-release] branch master updated: Expose dependency.dev and dependency.rel properties

2019-10-28 Thread Robert Scholte
I wrote an extra integration test, it confirms still change is indeed required to match the original requirements. Robert On 27-10-2019 20:26:37, Petar Tahchiev wrote: I think it's fine. I don't think it's going to break anything. For some reason these changes got left behind and I had to add

Re: [maven-release] branch master updated: Expose dependency.dev and dependency.rel properties

2019-10-27 Thread Petar Tahchiev
I think it's fine. I don't think it's going to break anything. For some reason these changes got left behind and I had to add them. На нд, 27.10.2019 г. в 21:00 ч. Robert Scholte написа: > I thought this was already fixed (as the issue is closed). I remember we > had a discussion about the

Re: [maven-release] branch master updated: Expose dependency.dev and dependency.rel properties

2019-10-27 Thread Robert Scholte
I thought this was already fixed (as the issue is closed). I remember we had a discussion about the solution, just want to be sure you don't break anything. This should already have been covered by an integrationtest, so I'm suprised by this change. On 27-10-2019 19:46:25, Petar Tahchiev

Re: [maven-release] branch master updated: Expose dependency.dev and dependency.rel properties

2019-10-27 Thread Petar Tahchiev
Hi Robert, yes I noticed today it somehow was left behind. As the message in the commit says it is for MRELEASE-985 and we need it to be able to override certain dependency versions from command line. На нд, 27.10.2019 г. в 20:35 ч. Robert Scholte написа: > Hi Petar, > > Is this related to

Re: [maven-release] branch master updated: Expose dependency.dev and dependency.rel properties

2019-10-27 Thread Robert Scholte
Hi Petar,  Is this related to https://issues.apache.org/jira/browse/MRELEASE-985 [https://issues.apache.org/jira/browse/MRELEASE-985] ?  Robert On 27-10-2019 08:22:12, ptahch...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. ptahchiev pushed a commit to