Re: ASM leaking into my plugin build

2016-07-19 Thread Paul Benedict
Thanks Robert. Congratulations on the outstanding research. Personally I am surprised that the Maven Plugin Plugin was scanning *all* my dependencies. I have nothing to offer it. :-) My project source is where my Mojo annotations are and not in any dependencies. So when I reported a suspected ASM

Re: ASM leaking into my plugin build

2016-07-19 Thread Robert Scholte
Hi, after some investigation Paul and I have good news: *none* of the classes is leaking into the plugin. Some details: the Annotation scanners doesn't only scan the compiled classes in the outputDirectory, but also in all the dependencies in search for other (Abstract)Mojo's. One of the

Re: ASM leaking into my plugin build

2016-07-18 Thread Robert Scholte
sure On Mon, 18 Jul 2016 22:13:46 +0200, Paul Benedict wrote: Sure, I'll just have to produce a dummy example from my current project. Can I mail you a zip personally? Cheers, Paul On Mon, Jul 18, 2016 at 3:10 PM, Robert Scholte wrote: Do you

Re: ASM leaking into my plugin build

2016-07-18 Thread Paul Benedict
Sure, I'll just have to produce a dummy example from my current project. Can I mail you a zip personally? Cheers, Paul On Mon, Jul 18, 2016 at 3:10 PM, Robert Scholte wrote: > Do you have the code somewhere so we can have a look at what's happening? > I did a quick look

Re: ASM leaking into my plugin build

2016-07-18 Thread Robert Scholte
Do you have the code somewhere so we can have a look at what's happening? I did a quick look at the scanner code but can't find a reason why ASM should be leaking. Robert On Mon, 18 Jul 2016 22:03:23 +0200, Paul Benedict wrote: If I may expand this thread to the

Re: ASM leaking into my plugin build

2016-07-18 Thread Paul Benedict
If I may expand this thread to the subject of class loaders, how is it possible that a plugin's own dependencies can ever leak into mine? I know shading is a common solution, but I am curious why this particular situation can occur at all. Got any insight on the matter? I read the stock

Re: ASM leaking into my plugin build

2016-07-18 Thread Robert Scholte
On Mon, 18 Jul 2016 19:18:36 +0200, Paul Benedict wrote: Hi. It seems when I build my maven plugin, ASM is being used to scan for my Mojo annotations. I use ASM internally for my own code. My ASM is the latest 6.0_ALPHA and it's causing an NPE when the Maven Plugin

ASM leaking into my plugin build

2016-07-18 Thread Paul Benedict
Hi. It seems when I build my maven plugin, ASM is being used to scan for my Mojo annotations. I use ASM internally for my own code. My ASM is the latest 6.0_ALPHA and it's causing an NPE when the Maven Plugin Plugin executes. If I downgrade to something less, then there is no interference with the