Re: Common Bugs

2008-04-08 Thread Vincent Siveton
2008/4/7, Benjamin Bentmann [EMAIL PROTECTED]: I wonder if it's worth posting these as a series under the developers section of the Maven site? Vincent and I had already put parts of this stuff onto [0] in a section named Some Pitfalls, together with a link to this mail thread. But I

Re: Common Bugs

2008-04-07 Thread Benjamin Bentmann
I wonder if it's worth posting these as a series under the developers section of the Maven site? Vincent and I had already put parts of this stuff onto [0] in a section named Some Pitfalls, together with a link to this mail thread. But I agree, having all of this in a nicely formatted APT doc

Re: Common Bugs

2008-04-06 Thread Benjamin Bentmann
Hi, 6) URLs and Filesystem Paths URLs and filesystem paths are really two different beasts and converting between them is not trivial. The main source of problems is that different encoding rules apply for the strings that make up a URL or filesystem path. For example, consider the

Re: Common Bugs

2008-04-06 Thread Benjamin Bentmann
new File( new URI( url.toString() ) ) Correction: JRE 1.4 is happily returning invalid/unescaped URLs from ClassLoader.getResource(), making the above suggestion fail with a URISyntaxException. The new suggestion is to use FileUtils.toFile(URL) [0] from Commons IO. A similar methods

Re: Common Bugs

2008-04-06 Thread Brett Porter
Hey Benjamin, I wonder if it's worth posting these as a series under the developers section of the Maven site? - Brett On 06/04/2008, at 9:46 PM, Benjamin Bentmann wrote: new File( new URI( url.toString() ) ) Correction: JRE 1.4 is happily returning invalid/unescaped URLs from

Re: Common Bugs

2008-04-06 Thread Barrie Treloar
On Mon, Apr 7, 2008 at 6:21 AM, Brett Porter [EMAIL PROTECTED] wrote: Hey Benjamin, I wonder if it's worth posting these as a series under the developers section of the Maven site? And building custom Checsktyle/PMD rules (if built in ones dont exist) to flag these as error?

Re: Common Bugs

2008-03-08 Thread Benjamin Bentmann
Hi, 5) Reading and Writing Text Files Textual content is composed of characters while file systems merely store byte streams. A file encoding (aka charset) is used to convert between bytes and characters. The challenge is using the right file encoding... The JVM has this notion of a default

Re: Common Bugs

2008-02-02 Thread Benjamin Bentmann
Hi again, 4) Effective Output Directory for Report Plugins Most reporting plugins will inherit from AbstractMavenReport. In doing so, they need to implement the inherited but abstract method getOutputDirectory(). To implement this method, plugins usually declare a field named outputDirectory

Re: Common Bugs

2008-01-17 Thread Benjamin Bentmann
Greetings, I remember another subtle issue which I would like to make people aware of. 3) Case-Insensitive String Comparison When developers need to compare strings without regard to case or want to realize a map with case-insensitive string keys, they often employ String.toLowerCase() or

RE: Common Bugs

2008-01-14 Thread Timothy Reilly
Just an observation, but would it not be a good idea to codify these heuristics in a plugin and add them to the plugins pom. For example, PMD or some other plugin might generate violations for these. - To unsubscribe,

Re: Common Bugs

2008-01-14 Thread Brett Porter
That sounds like a great idea :) - Brett On 15/01/2008, at 12:35 AM, Timothy Reilly wrote: Just an observation, but would it not be a good idea to codify these heuristics in a plugin and add them to the plugins pom. For example, PMD or some other plugin might generate violations for these.

Common Bugs

2008-01-13 Thread Benjamin Bentmann
Dear developers, After some months of reporting issues for Maven, I have noticed common bugs in various plugins. For me it seems that many developers are either completely unaware of the problems (i.e. do not handle them at all) or are misunderstanding them (i.e. handle them insufficiently

Re: Common Bugs

2008-01-13 Thread Milos Kleint
noticed common bugs in various plugins. For me it seems that many developers are either completely unaware of the problems (i.e. do not handle them at all) or are misunderstanding them (i.e. handle them insufficiently). Therefore, I would like to illustrate the source of those problems in more detail