Re: MNG-6123 for Maven 3.5.1

2017-07-30 Thread Robert Scholte
Hi Karl Heinz, comparing the key is often good enough, but I wonder if we should include the packaging type as well. On the other hand, if there's another module with the same GA, then you'll have an issue as well. Would be good to add a comment here that says ignoring type and classifier

Re: MNG-6123 for Maven 3.5.1

2017-07-30 Thread Karl Heinz Marbaise
Hi Robert, On 30/07/17 12:56, Robert Scholte wrote: I'm missing the code change, I see only IT changes. Sure...missed the link: https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=65bb3030193db6b5c0d55c0f00f94f2dc77b801d On the branch: https://git-wip-us.apache.org/repos/asf?p=mav

Re: MNG-6123 for Maven 3.5.1

2017-07-30 Thread Robert Scholte
I'm missing the code change, I see only IT changes. On Fri, 28 Jul 2017 22:03:15 +0200, Karl Heinz Marbaise wrote: Hi, I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which needs a small change to one of the integration tests[2] The IT's are fine see[3] Are any object

MNG-6123 for Maven 3.5.1

2017-07-28 Thread Karl Heinz Marbaise
Hi, I would like to integrate MNG-6123[1] into Maven 3.5.1 (master)..which needs a small change to one of the integration tests[2] The IT's are fine see[3] Are any objections? If there are no objections I would like to merge to master on tuesday... Kind regards Karl Heinz Marbaise [1]: ht