Re: Maven Code Style and imports layouts

2021-11-27 Thread Hervé BOUTEMY
no objection, PR merged for enforcing, it can be a future enhancement if someone contributes Regards, Hervé Le samedi 13 novembre 2021, 19:49:09 CET Romain Manni-Bucau a écrit : > While enforced at mvn package +1 from me > > Le sam. 13 nov. 2021 à 15:04, Hervé BOUTEMY a > > écrit : > > I

Re: Maven Code Style and imports layouts

2021-11-13 Thread Romain Manni-Bucau
While enforced at mvn package +1 from me Le sam. 13 nov. 2021 à 15:04, Hervé BOUTEMY a écrit : > I had a look at https://github.com/apache/maven-site/pull/269 > > seems reasonable: we'll just need to have someone implement the same for > Eclipse format > > if nobody objects, I'll merge in 1

Re: Maven Code Style and imports layouts

2021-11-13 Thread Hervé BOUTEMY
I had a look at https://github.com/apache/maven-site/pull/269 seems reasonable: we'll just need to have someone implement the same for Eclipse format if nobody objects, I'll merge in 1 week Regards, Hervé Le vendredi 17 septembre 2021, 23:19:25 CET Slawomir Jaranowski a écrit : > Hi, > > We

Re: Maven Code Style and imports layouts

2021-10-26 Thread Slawomir Jaranowski
Hi, Benjamin - thanks for voting. Can we finish this task? I assume that there are no -1 votes so it should be processed ... Any other suggestions, improvements? pon., 18 paź 2021 o 08:28 Benjamin Marwell napisał(a): > +1! > > Sandra and I tried similar Suggestions a while back. > This will

Re: Maven Code Style and imports layouts

2021-10-18 Thread Xeno Amess
...if there be a style restriction, adding it to CI is necessary. Benjamin Marwell 于2021年10月18日周一 下午2:28写道： > +1! > > Sandra and I tried similar Suggestions a while back. > This will help new contributors a lot. > > Thanks for your efforts! > > On Mon, 18 Oct 2021, 07:10 Slawomir Jaranowski,

Re: Maven Code Style and imports layouts

2021-10-18 Thread Benjamin Marwell
+1! Sandra and I tried similar Suggestions a while back. This will help new contributors a lot. Thanks for your efforts! On Mon, 18 Oct 2021, 07:10 Slawomir Jaranowski, wrote: > Hi, > > In order to help make decisions, I prepared PR [1] with the most used order > layout in Maven Core. > >

Re: Maven Code Style and imports layouts

2021-10-17 Thread Slawomir Jaranowski
Hi, In order to help make decisions, I prepared PR [1] with the most used order layout in Maven Core. Please look and vote / approve / choose another proposition. [1] https://github.com/apache/maven-site/pull/269 czw., 23 wrz 2021 o 23:47 Slawomir Jaranowski napisał(a): > Hi > > I checked

Re: Maven Code Style and imports layouts

2021-09-23 Thread Slawomir Jaranowski
Hi I checked the maven core project to see how many files don't meet the proposed layout. All imports in each group are alphabetically sorted. 1, - import javax.* - import java.* - blank line - all other imports - blank line - import static all other imports -> 285 files to change 2. -

Re: Maven Code Style and imports layouts

2021-09-18 Thread Elliotte Rusty Harold
simpler is better, though perhaps the fundamental rule should be don't reporter what's already there. That is, avoid needless churn. My preferred style is: static imports blank line all other imports alphabetically On Fri, Sep 17, 2021 at 9:19 PM Slawomir Jaranowski wrote: > > Hi, > > We have

Maven Code Style and imports layouts

2021-09-17 Thread Slawomir Jaranowski
Hi, We have described many rules about code style on Maven Code Style And Code Conventions [1]. One item missing for me is how java imports should be ordered and groped. I can setup it in IDE and it is very useful to use code formatting with tools. I think that all propositions in this case will