Re: Maven issue with JDK16 - javac and javadoc

Hi, sorry for the late reply… Enrico I think the latest version should work, and here is the IT (I just didn’t create a PR yet): https://github.com/apache/maven-compiler-plugin/pull/37 MCOMPILER-445/pom.xml succeeds, other tests fail because of an outdated groovy plugin. I will push another

Re: Maven issue with JDK16 - javac and javadoc

On 12 Nov 2020, at 14:50, Graham Leggett wrote: > I have been smashing my head against the javadoc plugin and > maven-release-plugin, which keeps failing releases over and over again on the > basis that the docs can’t be built. > > In the absence of a way to fix this, if there is a way to

Re: Maven issue with JDK16 - javac and javadoc

I am testing latest build of openjdk16, it seems to me that the problem has been resolved Benjamin, can you please try ? probably there is no need for a fix on Maven Enrico Il giorno lun 14 dic 2020 alle ore 22:12 Benjamin Marwell < bmarw...@apache.org> ha scritto: > > I'm pretty sure

Re: Maven issue with JDK16 - javac and javadoc

> I'm pretty sure this can be solved without touching the maven startup scripts. > And I don't like the idea to hack the script Agreed. I did not like the idea either, and even worse, I was unable to reproduce the results I had. Am Mo., 14. Dez. 2020 um 21:58 Uhr schrieb Robert Scholte <

Re: Maven issue with JDK16 - javac and javadoc

I'm pretty sure this can be solved without touching the maven startup scripts. And I don't like the idea to hack the script because one plugin has issues. I expect good help on your question on the jigsaw mailinglist. Robert On 14-12-2020 15:21:04, Benjamin Marwell wrote: I was able to provide a

Re: Maven issue with JDK16 - javac and javadoc

Il giorno lun 14 dic 2020 alle ore 15:21 Benjamin Marwell < bmarw...@apache.org> ha scritto: > I was able to provide a test, but the only solution to the underlying I > found was to modify the mvn start script by adding the missing modules (or > maybe even better: all system modules). > I tried

Re: Maven issue with JDK16 - javac and javadoc

I was able to provide a test, but the only solution to the underlying I found was to modify the mvn start script by adding the missing modules (or maybe even better: all system modules). >From what I could see from slack, plexus compiler would need to be a module, requiring jdk.javadoc. Thus, we

Re: Maven issue with JDK16 - javac and javadoc

JIRA issue (please kindly review): https://issues.apache.org/jira/browse/MCOMPILER-445 Am So., 13. Dez. 2020 um 14:07 Uhr schrieb Benjamin Marwell < bmarw...@apache.org>: > > If is has proven itself for jlink, then we know we can do the same for > all other tools. > > I tested my PR with a

Re: Maven issue with JDK16 - javac and javadoc

> If is has proven itself for jlink, then we know we can do the same for all other tools. I tested my PR with a JavaFX app and it did work. But there's no release yet, only the ITs and my test project. But adding a parameter to disable the ToolProvider as a fallback should not be a problem. A

Re: Maven issue with JDK16 - javac and javadoc

Yes, that makes a lot of sense. If is has proven itself for jlink, then we know we can do the same for all other tools. If we have a good feeling about the implementation, we could use it at reference for other plugins as some kind of pattern. Robert On 13-12-2020 11:39:02, Benjamin Marwell

Re: Maven issue with JDK16 - javac and javadoc

Il Dom 13 Dic 2020, 11:38 Benjamin Marwell ha scritto: > Robert already suggested to use ToolProvider for the JDK9+ builds. I > created such a patch for jlink and I could create s similar one for the > compiler and javadoc plugin. This would solve the underlying problem from > my understanding.

Re: Maven issue with JDK16 - javac and javadoc

Robert already suggested to use ToolProvider for the JDK9+ builds. I created such a patch for jlink and I could create s similar one for the compiler and javadoc plugin. This would solve the underlying problem from my understanding. As fork mode and fork count would not apply, I would suggest

Re: Maven issue with JDK16 - javac and javadoc

Is anyone interested in helping with this problem? Otherwise with the advent of jdk16 we will probably see people that need to switch to fork mode for javac, with slower builds, and we will see complaints from users The problem probably is is plexus compiler and the way we start javac, we should

Re: Maven issue with JDK16 - javac and javadoc

Yes, the problem is about javac with "no-fork + -Xdoclint" using no-fork is not a good option because it slows down a lot big multi module projects Enrico Il giorno gio 12 nov 2020 alle ore 13:55 Romain Manni-Bucau < rmannibu...@gmail.com> ha scritto: > @Graham I guess you can force the

Re: Maven issue with JDK16 - javac and javadoc

@Graham I guess you can force the compiler to fork and force doclint to none in javadoc plugin config (ensure to use a recent version). Romain Manni-Bucau @rmannibucau | Blog | Old Blog |

Re: Maven issue with JDK16 - javac and javadoc

On 12 Nov 2020, at 14:03, Enrico Olivelli wrote: > I have fallen into this issue about Maven + Maven Compiler Plugin + JDK16 > > This is the issue on JDK issue tracking > https://bugs.openjdk.java.net/browse/JDK-8253996 > > Basically -Xdoclint:missing does not work anymore when you run javac

Re: Maven issue with JDK16 - javac and javadoc

+1, got some weirdness on j11 too. We should really have a way to ignore these errors, it is too impacting, in particular when javadoc are only deployed to make central or our nexus happy. Romain Manni-Bucau @rmannibucau | Blog

Maven issue with JDK16 - javac and javadoc

Hi folks, I have fallen into this issue about Maven + Maven Compiler Plugin + JDK16 This is the issue on JDK issue tracking https://bugs.openjdk.java.net/browse/JDK-8253996 Basically -Xdoclint:missing does not work anymore when you run javac inside the same JVM as Maven core, because the JVM