Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-14 Thread Jason van Zyl
+1 > On May 14, 2022, at 6:26 AM, Tamás Cservenák wrote: > > +1 > > On Sun, May 8, 2022, 11:29 Hervé BOUTEMY wrote: > >> Hi, >> >> We solved 14 issues: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 >> >> Staging repo: >>

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-14 Thread Olivier Lamy
+1 On Sun, 8 May 2022 at 19:28, Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: > https://repository.apache.org/content/repositories/maven-1750/ > >

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-14 Thread Tamás Cservenák
+1 On Sun, May 8, 2022, 11:29 Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: > https://repository.apache.org/content/repositories/maven-1750/ > >

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-14 Thread Hervé BOUTEMY
thanks for checking: I'll add these 2 issues to the release Le vendredi 13 mai 2022, 17:08:21 CEST Jorge Solórzano a écrit : > +1 > > Tested on Linux with JDK17. > > I think this also fixes MWRAPPER-44 and fixes the abandoned > MWRAPPER-21 Zip-slip issue, making a total of 16 issues fixes ;) >

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-13 Thread Slawomir Jaranowski
+1 pt., 13 maj 2022 o 17:08 Jorge Solórzano napisał(a): > +1 > > Tested on Linux with JDK17. > > I think this also fixes MWRAPPER-44 and fixes the abandoned > MWRAPPER-21 Zip-slip issue, making a total of 16 issues fixes ;) > > > On Fri, May 13, 2022 at 9:29 AM Delany wrote: > > > > +1 > > > >

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-13 Thread Jorge Solórzano
+1 Tested on Linux with JDK17. I think this also fixes MWRAPPER-44 and fixes the abandoned MWRAPPER-21 Zip-slip issue, making a total of 16 issues fixes ;) On Fri, May 13, 2022 at 9:29 AM Delany wrote: > > +1 > > JDK11 on *nix > > Delany > > > On Fri, 13 May 2022 at 08:11, Herve Boutemy

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-13 Thread Delany
+1 JDK11 on *nix Delany On Fri, 13 May 2022 at 08:11, Herve Boutemy wrote: > here is my +1 > > Reproducible Build confirmed: reference done with JDK 8 on *nix > > I need more votes, please > > On 2022/05/08 09:28:32 Hervé BOUTEMY wrote: > > Hi, > > > > We solved 14 issues: > > >

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-13 Thread Herve Boutemy
ok, I was able to reproduce: yes, IT seems to expect wrapper.jar to have been previously installed: Tamas will bite because this is a build cycle :) I suppose this can easily be tested with SNAPSHOTs, you just have to delete the artifacts in local repository nice future improvement for the

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-13 Thread Herve Boutemy
here is my +1 Reproducible Build confirmed: reference done with JDK 8 on *nix I need more votes, please On 2022/05/08 09:28:32 Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: >

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-09 Thread Slawomir Jaranowski
Hi, Failed IT test during build from source-releas [1] We have almost done a new type distribution - only-script [2] which downloads the Maven distribution and calls directly the mvn script from distribution. I will be happy to provide this distribution to users for getting feedback. So

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-09 Thread Hervé BOUTEMY
mvnd is not only the CLI, it's also the daemon: if mvnd CLI does not manage different daemons for different versions, you'll not get the expected result I also see another question with mvnd CLI being a native GraalVM executable: we'll need to have the good native CLI expanded nothing is not

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-08 Thread James Gao
If mvnd always bundles a fixed version of Maven, from the wapper, maven daemon could be seen as a maven distribution, and if detected, the `mvnd` entry script is invoked instead of `mvn`. On Mon, May 9, 2022 at 2:59 AM Hervé BOUTEMY wrote: > currently mvnd does not support variable Maven

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-08 Thread Hervé BOUTEMY
currently mvnd does not support variable Maven versions then having wrapper for mvnd does not yet make sense Le dimanche 8 mai 2022, 14:12:31 CEST Slawomir Jaranowski a écrit : > HI > Delany what kind of integration do you think ...? Is there an issue created > for it? > > niedz., 8 maj 2022 o

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-08 Thread Hervé BOUTEMY
Le dimanche 8 mai 2022, 13:21:46 CEST Maarten Mulders a écrit : > With Maven 4 on macOS, neither `mvn wrapper:wrapper` nor `mvn wrapper` > picks up the new version. I guess we need a task to update Mavens > `WrapperLifecycleProvider` to achieve that? yes, because it's a fixed version we removed

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-08 Thread Slawomir Jaranowski
HI Delany what kind of integration do you think ...? Is there an issue created for it? niedz., 8 maj 2022 o 11:49 Delany napisał(a): > Hi. Is there integration between the wrapper and the upcoming mvnd? > > Thanks, > Delany > > > > On Sun, 8 May 2022 at 11:29, Hervé BOUTEMY wrote: > > > Hi, >

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-08 Thread Maarten Mulders
On 08/05/2022 11:28, Hervé BOUTEMY wrote: Hi, We solved 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 Staging repo: https://repository.apache.org/content/repositories/maven-1750/

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-08 Thread Delany
Hi. Is there integration between the wrapper and the upcoming mvnd? Thanks, Delany On Sun, 8 May 2022 at 11:29, Hervé BOUTEMY wrote: > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929=Text=12323721 > > Staging repo: >