Haven't seen a discussion in Slack or on the mailing list, so I guess no.
But I like the idea. Be aware that there are still Junit3 tests iirc.
Updating would be a breaking change, but that's okay for the upcoming Maven
4 release.
On Fri, 12 Aug 2022, 01:37 Vladimir V. Bychkov, wrote:
> H
I've migrated the Arquillian Spock Extension to use a
SessionLauncherListener (see the latest commits at
https://github.com/topicusonderwijs/arquillian-testrunner-spock/tree/spock-2.0-junit5
). This now works perfectly with the updated maven-surefire-plugin.
Arquillian is now only started once per
Hi Marc,
With forkCount = 1 it works fine, the problem is with forkCount > 1. The
Arquillian extension registers its state in the store at the root of the
TestPlan. When running with forkCount > 1, surefire sets up a load balancer
in the main process. This load balancer streams tests one by one to
Hi Emond,
could you please elaborate why the LauncherSessionListener approach doesn’t
work for forkCount=1 for Arquillian?
Cheers,
Marc
> On Sunday, Sep 12, 2021 at 9:37 PM, Emond Papegaaij
> mailto:emond.papega...@gmail.com)> wrote:
> Hi Marc,
>
> Thanks for the links to the documentation. T
Hi Marc,
Thanks for the links to the documentation. This really helps for my
Arquillian-Spock extension. It's good to know the LauncherSession was
introduced to solve this issue.
The problem I see with this new API is that it requires the extension to
explicitly make use of it. For example, the J
Hi Tibor,
I've reworked the commit to keep the JUnit version at 1.3 and use
reflection to get the session. Also, I've fixed the issue with the session
used for scanning tests in main thread that remained open. The formatting
is now in line with the checkstyle rules and all tests pass.
https://gith
LauncherSessionListener can be obviously used as a hack by the end users
but I do not see the reason why we should use it.
We do not want to explicitly call fixture methods because this would lead
to maintenance if Junit5 introduces new fixture mechanisms.
On Sat, Sep 11, 2021 at 12:25 PM Tibor Di
I do not want to stick to the latest version 1.8.
We have to stick to version 1.3 as it is right now.
We do not have a critical issue which could not be solved by reflection.
This reflection call, I proposed in GH, is made only once, no performance
penalty.
T
On Sat, Sep 11, 2021 at 7:52 AM Marc
Hi Emond and Tibor,
I’m glad you discovered the new LauncherSession API which was added for this
purpose. The JUnit 5.8 GA release will come in the next few days.
As you mentrioned, the official documentation does not (yet!) do a good job of
explaining its intended use case:
https://junit.org/j
Hi Emond,
This section of code is executed for the forkCount > 1
https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java#L194-L202
The above part runs if the forkCount is 1.
Do
Hi Tibor,
That's what I implemented, although I couldn't use the fancy try, because
of the way the code is structured. The LauncherSession is started by
LazyLauncher. This will allow registering a listener for opening and
closing the session, given a place for pre and post fixtures.
Best regards,
Hi Emond,
Are you looking for this?
https://github.com/junit-team/junit5/blob/main/documentation/src/test/java/example/UsingTheLauncherDemo.java#L86-L96
On Fri, Sep 10, 2021 at 10:49 PM Emond Papegaaij
wrote:
> On Fri, Sep 10, 2021 at 9:15 PM Emond Papegaaij >
> wrote:
>
> > On Fri, Sep 10, 20
On Fri, Sep 10, 2021 at 9:15 PM Emond Papegaaij
wrote:
> On Fri, Sep 10, 2021 at 8:41 PM Christian Stein
> wrote:
>
>> On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij <
>> emond.papega...@gmail.com>
>> wrote:
>>
>> For now, I think the LauncherSession is the best way to at least provide
>> > som
On Fri, Sep 10, 2021 at 8:41 PM Christian Stein wrote:
> On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij >
> wrote:
>
> For now, I think the LauncherSession is the best way to at least provide
> > some hooks for pre and post fixtures. It shouldn't be too hard to get
> this
> > in the current cod
Sorry for typos, I sent it from my mobile.
T
On Fri, Sep 10, 2021 at 6:18 PM Tibor Digana wrote:
> We have to dig into Junit 5. Surefire is a streamer of classes across the
> forks which is our load balancer. Therefore each class is running
> separately, pre and post fixtures. If the Junit 5 use
On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij
wrote:
> [...]
For now, I think the LauncherSession is the best way to at least provide
> some hooks for pre and post fixtures. It shouldn't be too hard to get this
> in the current code base with backwards compatibility for JUnit Platform
> 1.7 an
On Fri, Sep 10, 2021 at 6:18 PM Tibor Digana wrote:
> We have to dig into Junit 5. Surefire is a streamer of classes across the
> forks which is our load balancer. Therefore each class is running
> separately, pre and post fixtures. If the Junit 5 used Java Streamer
> including dome kind of contr
We have to dig into Junit 5. Surefire is a streamer of classes across the
forks which is our load balancer. Therefore each class is running
separately, pre and post fixtures. If the Junit 5 used Java Streamer
including dome kind of control of fixtures then web would have this issue.
Dňa pi 10. 9.
On Fri, Sep 10, 2021 at 5:06 PM Tibor Digana wrote:
> If you use forkCount > 1, the Surefire loads test classes via load
> balancer.
> If you use default forkCount = 0, all the classes are run eagerly as a
> suite via JUnit5 Launcher in one shot.
>
Yes, this is what I saw in the JUnitPlatformPro
Please read the documentation
https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
On Fri, Sep 10, 2021 at 5:05 PM Tibor Digana wrote:
> If you use forkCount > 1, the Surefire loads test classes via load
> balancer.
> If you use default forkCount = 0, all the classes a
If you use forkCount > 1, the Surefire loads test classes via load balancer.
If you use default forkCount = 0, all the classes are run eagerly as a
suite via JUnit5 Launcher in one shot.
If you are aiming for Arquillian, testing the applications in the
application server, you should use maven-fail
>>because Maven might just treat it as though it weren't set at all, and ignore
>>it.
One of our user pointed to the issue with empty property and I said it
is bug in Maven.
Somebody should fix it in Maven.
> The most useful of the three would be UNCATEGORIZED, so it can be combined
> with other
Hi Christopher,
Right the first test hangs but it does not call setOut(), after having
a look in your code.
UnusedWalDoesntCloseReplicationStatusIT
>>I wasn't aware it was hanging.
Running
org.apache.accumulo.test.replication.UnusedWalDoesntCloseReplicationStatusIT
Build timed out (after 300 mi
On Wed, Aug 31, 2016 at 4:43 AM Tibor Digana wrote:
> >>One thing we noticed was that the user property is the same for both
> plugins.
> We are aware of this and we will break the backwards compatibility.
> This change is planned in Surefire 3.0.
> I am thinking of temporary fix but better not t
On Wed, Aug 31, 2016 at 4:23 AM Tibor Digana wrote:
> Hi Christopher,
>
> Some offtopic. I will answer your email but first I have a question for you
> and Accumulo project.
> I visited Accumulo cca one week ago. Why the build [1] hangs on IT test
> executed by maven-failsafe-plugin:2.19.1?
>
I
>>One thing we noticed was that the user property is the same for both
plugins.
We are aware of this and we will break the backwards compatibility.
This change is planned in Surefire 3.0.
I am thinking of temporary fix but better not to do it.
Please reference and use these user/properties since th
Hi Christopher,
Some offtopic. I will answer your email but first I have a question for you
and Accumulo project.
I visited Accumulo cca one week ago. Why the build [1] hangs on IT test
executed by maven-failsafe-plugin:2.19.1?
I asked INFRA team to display Thread Dump button. Do you see this butt
Justin Edelson wrote:
I think the problem Kristian is identifying is that the junit:junit group
and artifact ids are hard-coded in the SurefirePlugin class. Relocation
won't help with this AFAICT.
It's already configurable [0] and could probably be extended to
recognize the new ids by default
On Tue, Jan 5, 2010 at 9:15 AM, Peter Lynch wrote:
> On Tue, Jan 5, 2010 at 7:47 AM, Kristian Rosenvold <
> kristian.rosenv...@gmail.com> wrote:
>
> > it should probably be org.junit but has since "the beginning of time"
> been
> > just junit. I know at least surefire would need to be updated if
On Tue, Jan 5, 2010 at 7:47 AM, Kristian Rosenvold <
kristian.rosenv...@gmail.com> wrote:
> I make the occasional submissions to the junit project, and I wanted to
> submit a pom.xml that'd convert it into a proper maven project.
>
> My real question is what/if anything should be done to the group
Benjamin Bentmann wrote:
I noticed that Maven is using junit:3.8.1 quite everywhere for its tests
although a later maintenance release of the 3.x line exists with junit:3.8.2.
Is there a known issue with 3.8.2 that makes one stick to 3.8.1?
I think it's just that JUnit 3.8.1 was released in 2
I'm not aware of any issues, doxia is using 3.8.2 everywhere.
-Lukas
Benjamin Bentmann wrote:
Hi,
I noticed that Maven is using junit:3.8.1 quite everywhere for its tests
although a later maintenance release of the 3.x line exists with
junit:3.8.2. Is there a known issue with 3.8.2 that make
Thanks for the response Patrick.
> > >
> > > I'm not having problems using Junit 4 (I'm actually using Surefire
> > > version 2.4-collab-SNAPSHOT because 2.4-SNAPSHOT is still broken).
> > >
> > > Just having problems getting any of the suite fu
cause 2.4-SNAPSHOT is still broken).
> >
> > Just having problems getting any of the suite functionality to work.
> > Frustrating...
> >
> > -Original Message-
> > From: Patrick He [mailto:[EMAIL PROTECTED]
> > Sent: Thursday, October 18, 2007 11:10
I've uploaded it to iBiblio so you can try it
On 2/19/06, Stefan Bodewig <[EMAIL PROTECTED]> wrote:
> On Sun, 19 Feb 2006, Arnaud HERITIER <[EMAIL PROTECTED]> wrote:
>
> > Yes but It seems that JUnit 4 works only with Java 5 ??
>
> It requires Java 5 to compile and annotations for JUnit 4 style
>
Hi all..
Though i did not test this using surefire (yet), I am almost certain
that it would work..
the followng testcode, and notice the inner suite() method.
package no.objectware.test.junit4;
import junit.framework.JUnit4TestAdapter;
import org.junit.After;
import org.junit.AfterClass;
imp
On Sun, 19 Feb 2006, Arnaud HERITIER <[EMAIL PROTECTED]> wrote:
> Yes but It seems that JUnit 4 works only with Java 5 ??
It requires Java 5 to compile and annotations for JUnit 4 style
tests. JUnit 3 style tests are still supported (so you can run your
old tests against JUnit 4) and don't requi
Yes but It seems that JUnit 4 works only with Java 5 ??
Arnaud
On 2/18/06, Grzegorz Słowikowski <[EMAIL PROTECTED]> wrote:
> Hi All
>
> JUnit 4.0 has just be released.
>
> http://sourceforge.net/projects/junit
>
> What I see is that it uses Java 5 annotations, and it's
> not backward compatible w
On Mon, 4 Aug 2003 04:50 pm, [EMAIL PROTECTED] wrote:
> You post them in our issue tracking system, Jira.
>
> See http://jira.codehaus.org/secure/BrowseProject.jspa?id=10030
Thanks dIon, Martin, Ben, Rafal and others in the future. I had been to that
page previously and couldn't make it work. In
John Farrell wrote:
> Hi all. I am a new Maven user. I believe I have tidied up and improved the
> junit report page. To whom do I send my changes? Thanks,
You should create an 'Improvement' issue in Maven's Jira, describe what
you did, and attach a patch (in unidiff format) to the issue. If your
http://wiki.codehaus.org/maven/SubmittingPatches
John Farrell wrote:
Hi all. I am a new Maven user. I believe I have tidied up and improved the
junit report page. To whom do I send my changes? Thanks,
John
-
To unsubscribe, e-
You post them in our issue tracking system, Jira.
See http://jira.codehaus.org/secure/BrowseProject.jspa?id=10030
--
dIon Gillard, Multitask Consulting
Blog: http://blogs.codehaus.org/people/dion/
John Farrell <[EMAIL PROTECTED]> wrote on 04/08/2003 04:38:11 PM:
> Hi all. I am a new Maven
Hi John,
On Mon, 2003-08-04 at 08:38, John Farrell wrote:
> Hi all. I am a new Maven user. I believe I have tidied up and improved the
> junit report page. To whom do I send my changes? Thanks,
Please create a issue on http://jira.codehaus.org
--
Martin Skopp
Riege Software International GmbH
S
43 matches
Mail list logo
