Re: Releasing Maven Shade Plugin

2020-02-08 Thread Hervé BOUTEMY
perfect plan: everything seems ready for the immediate release, the rest will come in a few months I'll start the release process Regards, Hervé Le samedi 8 février 2020, 10:44:15 CET Robert Scholte a écrit : > I wanted to wait for the next release for ASM, which will be released at the >

Re: Releasing Maven Shade Plugin

2020-02-08 Thread Robert Scholte
I think everybody can approve these PRs, so to me they are a bit misleading. I've already wiped away a couple of PRs this week, but I'd like to have a critical look at it. This plugin is very powerful, so it must be handled with great care. To me Hervé can release it, these PRs could be part of

Re: Releasing Maven Shade Plugin

2020-02-08 Thread Elliotte Rusty Harold
There are nine open PRs in the shade plugin repo, some approved. Can any of these be resolved before release? On Fri, Feb 7, 2020 at 6:47 PM Hervé BOUTEMY wrote: > > I'd like to release this plugin: anything to add before the release? > > Regards, > > Hervé > > > >

Re: Releasing Maven Shade Plugin

2020-02-08 Thread Romain Manni-Bucau
Id like the manifest transformer enhancements to be in if ok ( https://github.com/apache/maven-shade-plugin/pull/38). Very worse case we go with Robert proposal to duplicate the config but feature is important for me. Le sam. 8 févr. 2020 à 10:44, Robert Scholte a écrit : > I wanted to wait for

Re: Releasing Maven Shade Plugin

2020-02-08 Thread Robert Scholte
I wanted to wait for the next release for ASM, which will be released at the same time as Java 14. That would give me enough time to wipe out a lot of open issues. e.g. MSHADE-202 requires a release of dependency-tree, so that one needs to be released too. Still having a discussion about

Re: releasing the shade plugin

2008-09-26 Thread Brett Porter
No objections from me. IIRC, the issues that cropped up in July were taken care of. Mark, Dan? Cheers, Brett On 24/09/2008, at 6:11 AM, Jason van Zyl wrote: There are three bug fixes and I added transformer support for META- INF/services entries, and MANIFEST.MF files where you specify a

Re: releasing the shade plugin

2008-09-26 Thread Mark Hobson
I believe Dan's changes fixed my problem but no tests were added to prove this. Cheers, Mark 2008/9/26 Brett Porter [EMAIL PROTECTED]: No objections from me. IIRC, the issues that cropped up in July were taken care of. Mark, Dan? Cheers, Brett On 24/09/2008, at 6:11 AM, Jason van Zyl