Re: Second MNG-6261

2018-11-27 Thread Olivier Lamy
+1 On Wed, 28 Nov 2018 at 04:06, Robert Scholte wrote: > Patch has been updated based on review comments[1]. > Who can second this? > > thanks, > Robert > > [1] https://github.com/apache/maven/pull/192/files > > On Tue, 20 Nov 2018 18:27:50 +0100, Robert Scholte > > wrote: > > > Looking for

Re: Second MNG-6261

2018-11-27 Thread Enrico Olivelli
Il mar 27 nov 2018, 19:06 Robert Scholte ha scritto: > Patch has been updated based on review comments[1]. > Who can second this? > +1 for me I have approved the pr Enrico > > thanks, > Robert > > [1] https://github.com/apache/maven/pull/192/files > > On Tue, 20 Nov 2018 18:27:50 +0100,

Re: Second MNG-6261

2018-11-27 Thread Robert Scholte
Patch has been updated based on review comments[1]. Who can second this? thanks, Robert [1] https://github.com/apache/maven/pull/192/files On Tue, 20 Nov 2018 18:27:50 +0100, Robert Scholte wrote: Looking for someone to second this fix. thanks, Robert Relative parent POM resolution

Re: Second MNG-6261

2018-11-23 Thread Robert Scholte
thank you and Jesper for reviewing this PR, comments make sense. I'll wait for a new PR. thanks, Robert On Wed, 21 Nov 2018 02:01:05 +0100, Enrico Olivelli wrote: Il mar 20 nov 2018, 18:27 Robert Scholte ha scritto: Looking for someone to second this fix. thanks, Robert Relative

Re: Second MNG-6261

2018-11-20 Thread Enrico Olivelli
Il mar 20 nov 2018, 18:27 Robert Scholte ha scritto: > Looking for someone to second this fix. > > thanks, > Robert > > Relative parent POM resolution failing in 3.5.0 with complex multimodule > builds > https://issues.apache.org/jira/browse/MNG-6261 > >

Second MNG-6261

2018-11-20 Thread Robert Scholte
Looking for someone to second this fix. thanks, Robert Relative parent POM resolution failing in 3.5.0 with complex multimodule builds https://issues.apache.org/jira/browse/MNG-6261 https://github.com/apache/maven/pull/192/files