Re: maven-site-plugin and sisu-inject-plexus

2021-04-19 Thread Stuart McCulloch
On Sat, 17 Apr 2021 at 13:47, Elliotte Rusty Harold wrote: > I'd certainly prefer to use a fully supported, maintained, and > documented framework instead of Plexus. So about Sisu: > Sisu is basically a few modules installed on top of Guice to make it more dynamic, plus a thin compatibility

Re: maven-site-plugin and sisu-inject-plexus

2021-04-17 Thread Elliotte Rusty Harold
I'd certainly prefer to use a fully supported, maintained, and documented framework instead of Plexus. So about Sisu: Where is it documented? Is it under active development? When will 1.0 be released? Which projects besides Maven use it? On Sat, Apr 17, 2021 at 12:29 PM Tamás Cservenák wrote: >

Re: maven-site-plugin and sisu-inject-plexus

2021-04-17 Thread Tamás Cservenák
To be clear, am talking about this artifact (sisu plexus shim): https://repo1.maven.org/maven2/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.4/ Whenever you see plexus-container-default, you SHOULD replace it with this above (or better yet, convert to plain sisu). T On Sat, Apr 17, 2021, 14:25

Re: maven-site-plugin and sisu-inject-plexus

2021-04-17 Thread Tamás Cservenák
Plexus-container-default is NOT (and SHOULD NOT) be used anywhere, but the drop in sisu-plexus drop replacement should be used instead. If we use p-c-d anywhere (even in UTs), that's bad, as maven uses s-p instead. p-c-d is not used in maven for sure. T On Sat, Apr 17, 2021, 14:02 Elliotte

Re: maven-site-plugin and sisu-inject-plexus

2021-04-17 Thread Slawomir Jaranowski
So maybe it is time to start removing unnecessary code ... There is needed clear decision what component should be removed, what replaces it. In order to everybody know direction and target goal. Eg. plexus-container-default - should be removed at all org.codehaus.plexus.logging -> sl4j .. and

Re: maven-site-plugin and sisu-inject-plexus

2021-04-17 Thread Elliotte Rusty Harold
plexus-container-default is used by Maven shared utils and thus by almost everything in Maven. Not that this is a good thing, but c'est la vie. There's a lot of over-engineered, unnecessary code splitting between Maven, Aether, Plexus, and Modello. Maven's a pretty classic example of why

Re: maven-site-plugin and sisu-inject-plexus

2021-02-09 Thread Hervé BOUTEMY
PlexusContainer is used by AbstractDeployMojo: it's a good thing to keep an explicit direct dependency, even if it's also a transitive on this class being both in plexus-container and sisu-inject, it's because sisu-inject is meant to be a replacement: it's not a bug, it's a feature on runtime

Re: maven-site-plugin and sisu-inject-plexus

2021-02-09 Thread Tamás Cservenák
Sorry, but I have to clarify this "Plexus et al is one of the reasons..." misleading statement: It is not Plexus per se THE reason, but the "neglected and stale" dependencies, or better "dependencies like these"... T On Tue, Feb 9, 2021 at 5:38 PM Tamás Cservenák wrote: > Howdy, > > my 5

Re: maven-site-plugin and sisu-inject-plexus

2021-02-09 Thread Tamás Cservenák
Howdy, my 5 cents: Something is stale, very stale in there, as plexus-container-default was abandoned about 10 (maybe 12?) years ago, and sisu "shim" (sisu-inject-plexus) was created as the direct replacement (as functional and as API). If your project has Plexus "the old container"

Re: maven-site-plugin and sisu-inject-plexus

2021-02-09 Thread Slawomir Jaranowski
Project used class like org.codehaus.plexus.PlexusContainer We can remove direct dependency because we have transitive dependency from other artifacts - of course we needn't remove it. [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ maven-site-plugin --- [WARNING] Using Maven 2

Re: maven-site-plugin and sisu-inject-plexus

2021-02-09 Thread Elliotte Rusty Harold
Seems maven dependency:analyze thinks we need this one. At least it doesn't call it out as unused: [WARNING] Used undeclared dependencies found: [WARNING]javax.servlet:javax.servlet-api:jar:3.1.0:compile [WARNING] Unused declared dependencies found: [WARNING]

Re: maven-site-plugin and sisu-inject-plexus

2021-02-09 Thread Elliotte Rusty Harold
What does maven dependency:analyze say? On Tue, Feb 9, 2021 at 2:25 PM Emmanuel Bourg wrote: > > Hi, > > maven-site-plugin has a dependency on sisu-inject-plexus [1] but it > doesn't seem to be used. The project still builds and the tests pass > without it. > > Is it safe to assume it can be

maven-site-plugin and sisu-inject-plexus

2021-02-09 Thread Emmanuel Bourg
Hi, maven-site-plugin has a dependency on sisu-inject-plexus [1] but it doesn't seem to be used. The project still builds and the tests pass without it. Is it safe to assume it can be removed? Emmanuel Bourg [1]